From 2814c7857f1cdbb35cdad21bf3bc160a6b29021b Mon Sep 17 00:00:00 2001 From: Freddy Caceres Date: Tue, 4 Apr 2023 10:32:49 -0400 Subject: [PATCH] imp: remove distribution perms (#1739) * imp: remove distribution perms * update changelog --- CHANGELOG.md | 872 +++++++++++++++++++++++++-------------------------- app/app.go | 4 +- 2 files changed, 437 insertions(+), 439 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75aada6eed..b5464c80be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,3 @@ - `MsgEthereumTx` and `EmintMsg` --> `MsgEthermint` for consistency with SDK standards - * Updated integration and unit tests to use `EthermintApp` as testing suite - * Use expected `Keeper` interface for `AccountKeeper` - * Replaced `count` type in keeper with `int` - * Add SDK events for transactions -* [tharsis#236](https://github.com/cosmos/ethermint/pull/236) Changes from upgrade: - * (`app/ante`) Moved `AnteHandler` implementation to `app/ante` - * (keys) Marked `ExportEthKeyCommand` as **UNSAFE** - * (evm) Moved `BeginBlock` and `EndBlock` to `x/evm/abci.go` -* (evm) [tharsis#255](https://github.com/cosmos/ethermint/pull/255) Add missing `GenesisState` fields and support `ExportGenesis` functionality. -* [tharsis#272](https://github.com/cosmos/ethermint/pull/272) Add `Logger` for evm module. -* [tharsis#317](https://github.com/cosmos/ethermint/pull/317) `GenesisAccount` validation. -* (evm) [tharsis#319](https://github.com/cosmos/ethermint/pull/319) Various evm improvements: - * Add transaction `[]*ethtypes.Logs` to evm's `GenesisState` to persist logs after an upgrade. - * Remove evm `CodeKey` and `BlockKey`in favor of a prefix `Store`. - * Set `BlockBloom` during `EndBlock` instead of `BeginBlock`. - * `Commit` state object and `Finalize` storage after `InitGenesis` setup. -* (rpc) [tharsis#325](https://github.com/cosmos/ethermint/pull/325) `eth_coinbase` JSON-RPC query now returns the node's validator address. +- (sdk) [tharsis#386](https://github.com/cosmos/ethermint/pull/386) Bump Cosmos SDK version to [v0.39.1](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.39.1) +- (evm) [tharsis#181](https://github.com/cosmos/ethermint/issues/181) Updated EVM module to the recommended module structure. +- (app) [tharsis#188](https://github.com/cosmos/ethermint/issues/186) Misc cleanup: + - (evm) Rename `EthereumTxMsg` --> `MsgEthereumTx` and `EmintMsg` --> `MsgEthermint` for consistency with SDK standards + - Updated integration and unit tests to use `EthermintApp` as testing suite + - Use expected `Keeper` interface for `AccountKeeper` + - Replaced `count` type in keeper with `int` + - Add SDK events for transactions +- [tharsis#236](https://github.com/cosmos/ethermint/pull/236) Changes from upgrade: + - (`app/ante`) Moved `AnteHandler` implementation to `app/ante` + - (keys) Marked `ExportEthKeyCommand` as **UNSAFE** + - (evm) Moved `BeginBlock` and `EndBlock` to `x/evm/abci.go` +- (evm) [tharsis#255](https://github.com/cosmos/ethermint/pull/255) Add missing `GenesisState` fields and support `ExportGenesis` functionality. +- [tharsis#272](https://github.com/cosmos/ethermint/pull/272) Add `Logger` for evm module. +- [tharsis#317](https://github.com/cosmos/ethermint/pull/317) `GenesisAccount` validation. +- (evm) [tharsis#319](https://github.com/cosmos/ethermint/pull/319) Various evm improvements: + - Add transaction `[]*ethtypes.Logs` to evm's `GenesisState` to persist logs after an upgrade. + - Remove evm `CodeKey` and `BlockKey`in favor of a prefix `Store`. + - Set `BlockBloom` during `EndBlock` instead of `BeginBlock`. + - `Commit` state object and `Finalize` storage after `InitGenesis` setup. +- (rpc) [tharsis#325](https://github.com/cosmos/ethermint/pull/325) `eth_coinbase` JSON-RPC query now returns the node's validator address. ### Features -* (build) [tharsis#378](https://github.com/cosmos/ethermint/pull/378) Create multi-node, local, automated testnet setup with `make localnet-start`. -* (rpc) [tharsis#330](https://github.com/cosmos/ethermint/issues/330) Implement `PublicFilterAPI`'s `EventSystem` which subscribes to Tendermint events upon `Filter` creation. -* (rpc) [tharsis#231](https://github.com/cosmos/ethermint/issues/231) Implement `NewBlockFilter` in rpc/filters.go which instantiates a polling block filter - * Polls for new blocks via `BlockNumber` rpc call; if block number changes, it requests the new block via `GetBlockByNumber` rpc call and adds it to its internal list of blocks - * Update `uninstallFilter` and `getFilterChanges` accordingly - * `uninstallFilter` stops the polling goroutine - * `getFilterChanges` returns the filter's internal list of block hashes and resets it -* (rpc) [tharsis#54](https://github.com/cosmos/ethermint/issues/54), [tharsis#55](https://github.com/cosmos/ethermint/issues/55) +- (build) [tharsis#378](https://github.com/cosmos/ethermint/pull/378) Create multi-node, local, automated testnet setup with `make localnet-start`. +- (rpc) [tharsis#330](https://github.com/cosmos/ethermint/issues/330) Implement `PublicFilterAPI`'s `EventSystem` which subscribes to Tendermint events upon `Filter` creation. +- (rpc) [tharsis#231](https://github.com/cosmos/ethermint/issues/231) Implement `NewBlockFilter` in rpc/filters.go which instantiates a polling block filter + - Polls for new blocks via `BlockNumber` rpc call; if block number changes, it requests the new block via `GetBlockByNumber` rpc call and adds it to its internal list of blocks + - Update `uninstallFilter` and `getFilterChanges` accordingly + - `uninstallFilter` stops the polling goroutine + - `getFilterChanges` returns the filter's internal list of block hashes and resets it +- (rpc) [tharsis#54](https://github.com/cosmos/ethermint/issues/54), [tharsis#55](https://github.com/cosmos/ethermint/issues/55) Implement `eth_getFilterLogs` and `eth_getLogs`: - * For a given filter, look through each block for transactions. If there are transactions in the block, get the logs from it, and filter using the filterLogs method - * `eth_getLogs` and `eth_getFilterChanges` for log filters use the same underlying method as `eth_getFilterLogs` - * update `HandleMsgEthereumTx` to store logs using the ethereum hash -* (app) [tharsis#187](https://github.com/cosmos/ethermint/issues/187) Add support for simulations. + - For a given filter, look through each block for transactions. If there are transactions in the block, get the logs from it, and filter using the filterLogs method + - `eth_getLogs` and `eth_getFilterChanges` for log filters use the same underlying method as `eth_getFilterLogs` + - update `HandleMsgEthereumTx` to store logs using the ethereum hash +- (app) [tharsis#187](https://github.com/cosmos/ethermint/issues/187) Add support for simulations. ### Bug Fixes -* (evm) [tharsis#767](https://github.com/cosmos/ethermint/issues/767) Fix error of timeout when using Truffle to deploy contract. -* (evm) [tharsis#751](https://github.com/cosmos/ethermint/issues/751) Fix misused method to calculate block hash in evm related function. -* (evm) [tharsis#721](https://github.com/cosmos/ethermint/issues/721) Fix mismatch block hash in rpc response when use eth.getBlock. -* (evm) [tharsis#730](https://github.com/cosmos/ethermint/issues/730) Fix 'EIP2028' not open when Istanbul version has been enabled. -* (app) [tharsis#749](https://github.com/cosmos/ethermint/issues/749) Fix panic in `AnteHandler` when gas price larger than 100000 -* (rpc) [tharsis#305](https://github.com/cosmos/ethermint/issues/305) Update `eth_getTransactionCount` to check for account existence before getting sequence and return 0 as the nonce if it doesn't exist. -* (evm) [tharsis#319](https://github.com/cosmos/ethermint/pull/319) Fix `SetBlockHash` that was setting the incorrect height during `BeginBlock`. -* (evm) [tharsis#176](https://github.com/cosmos/ethermint/issues/176) Updated Web3 transaction hash from using RLP hash. Now all transaction hashes exposed are amino hashes: - * Removes `Hash()` (RLP) function from `MsgEthereumTx` to avoid confusion or misuse in future. +- (evm) [tharsis#767](https://github.com/cosmos/ethermint/issues/767) Fix error of timeout when using Truffle to deploy contract. +- (evm) [tharsis#751](https://github.com/cosmos/ethermint/issues/751) Fix misused method to calculate block hash in evm related function. +- (evm) [tharsis#721](https://github.com/cosmos/ethermint/issues/721) Fix mismatch block hash in rpc response when use eth.getBlock. +- (evm) [tharsis#730](https://github.com/cosmos/ethermint/issues/730) Fix 'EIP2028' not open when Istanbul version has been enabled. +- (app) [tharsis#749](https://github.com/cosmos/ethermint/issues/749) Fix panic in `AnteHandler` when gas price larger than 100000 +- (rpc) [tharsis#305](https://github.com/cosmos/ethermint/issues/305) Update `eth_getTransactionCount` to check for account existence before getting sequence and return 0 as the nonce if it doesn't exist. +- (evm) [tharsis#319](https://github.com/cosmos/ethermint/pull/319) Fix `SetBlockHash` that was setting the incorrect height during `BeginBlock`. +- (evm) [tharsis#176](https://github.com/cosmos/ethermint/issues/176) Updated Web3 transaction hash from using RLP hash. Now all transaction hashes exposed are amino hashes: + - Removes `Hash()` (RLP) function from `MsgEthereumTx` to avoid confusion or misuse in future. diff --git a/app/app.go b/app/app.go index 7e5b3e8982..dd744e25dd 100644 --- a/app/app.go +++ b/app/app.go @@ -193,9 +193,7 @@ var ( } // module accounts that are allowed to receive tokens - allowedReceivingModAcc = map[string]bool{ - distrtypes.ModuleName: true, - } + allowedReceivingModAcc = map[string]bool{} ) // var _ server.Application (*EthermintApp)(nil)