Cleanup is overzealous

[jskeate]

Example -- two cloaked collections in one page. For this example they both render the same list, which is just [0-199]

The issue occurs if you open them both, then close one. Seems like this kills the scroll event listener for all cloaked collections.

Also odd: on the initial toggle, it doesn't render to fill the viewport. For me it gets to 27, then stops. Also the second list never renders 199, and 198 is dodgy too.

[runspired]

I can fix this on the es6 branch, thanks for the detailed report!

I bumped into this last week where multiple instances (not even on the same route) would cause this to happen.

[runspired]

Just pinging to let you know I'm starting work on this today after making any necessary HTMLBars changes

[runspired]

@jskeate This is now fixed on the es6-flattened branch.

@eviltrout I appended the cloaked-collection view's element ID to the listener ID to avoid removing the listener for other instances during teardown. In my case, I use liquid-fire for animated transitions, which means the old view doesn't get torn down before the new view get's inserted, leading to instances on separate routes also colliding with each other.

[eviltrout]

@runspired sounds good. Once I started on the HTMLBars branch of Discourse I will be looking at this more closely. Until then thanks for your work!