Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StructureUnderAttack of Notifications cant work #864

Open
fengziyan331 opened this issue Mar 15, 2022 · 1 comment
Open

StructureUnderAttack of Notifications cant work #864

fengziyan331 opened this issue Mar 15, 2022 · 1 comment
Labels
bug good first issue Good for newcomers packages/notifications Issues related to notification package or its dependencies.

Comments

@fengziyan331
Copy link

  • Problem: when i use the StructureUnderAttack of Notifications failed
  • Expected:
  • Logs / Screenshots / Proof:ErrorException: sprintf(): Too few arguments in /var/www/seat/vendor/eveseat/notifications/src/Notifications/Structures/Mail/StructureUnderAttack.php:76
  • Version Info:
    SeAT API: v4.7.0
    SeAT Console : v4.8.0
    SeAT Eve API : v4.16.1
    SeAT Notifications: v4.3.1
    SeAT Services: v4.2.0
    SeAT Web : v4.17.0

I used the same setup to test other notifications,that's ok.
I see the code,the StructureUnderAttack.php:76 is

->line(
sprintf('Citadel (%s, "%s") attacked')
)

I‘m not a php programmer,did (%s, "%s") is right?

@warlof warlof added bug packages/notifications Issues related to notification package or its dependencies. good first issue Good for newcomers labels Mar 15, 2022
@warlof
Copy link
Member

warlof commented Mar 15, 2022

Syntax is valid, but there is no replacement value. That should be an easy fix for newcomer though 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers packages/notifications Issues related to notification package or its dependencies.
Projects
None yet
Development

No branches or pull requests

2 participants