On-resolve result suffix property also requires path property?

[IanBellomy]

In the mock plugin below, I expected onLoad's args.suffix to match what was returned from onResolve, but it's only there if path is also included in the onResolve results.

I have no experience with bundler plugins though and so assume this is working as expected and that I'm just missing some common knowledge, but it may be nice if the docs noted the path requirement. ✌️

import * as path from "path";
export const test = (options = {}) => ({
	name: "test",
	setup(build) {
		build.onResolve({ filter: /\.svg$/ }, async (args) => {
			if (!args.suffix) {
				return {
					suffix: "?my-suffix"
					// path: path.join(args.resolveDir, args.path), // suffix is only set if path included
				};
			}
		});
		
		build.onLoad({ filter: /\.svg$/ }, async (args) => {
			console.log("test suffix", args.suffix); // suffix is "" unless path is included in onResolve
		});
	},
});

[evanw]

This is because esbuild only uses the value returned by onResolve if it successfully resolves the path (either by returning a path or setting external: true. I can generate a warning when this happens.