Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsPackagePath does not consider aliases from tsconfig.json #3003

Closed
gorbak25 opened this issue Mar 18, 2023 · 2 comments
Closed

IsPackagePath does not consider aliases from tsconfig.json #3003

gorbak25 opened this issue Mar 18, 2023 · 2 comments

Comments

@gorbak25
Copy link

gorbak25 commented Mar 18, 2023

func IsPackagePath(path string) bool {

When bundling for nodejs with --packages=external enabled if there is an alias in tsconfig this function will classify such an import as an external module instead of an internal one.
Here is a minimal reproduction https://github.com/gorbak25/esbuild-bug-IsPackagePath

@devlsh
Copy link

devlsh commented Mar 20, 2023

Also currently experiencing this myself.

@evanw
Copy link
Owner

evanw commented Jul 22, 2023

Linking this issue to #3238.

@evanw evanw closed this as completed in cb46459 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants