Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unmaintained errors pkg(github.com/pkg/errors) #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove unmaintained errors pkg(github.com/pkg/errors) #206

wants to merge 1 commit into from
+111 −117

Conversation

koba1t
Copy link

@koba1t koba1t commented Jun 9, 2024

fix: #205

@koba1t koba1t force-pushed the remove_unmaintained_error_pkg branch from 3ec657b to 106306d Compare June 9, 2024 16:58
cbandy
cbandy approved these changes Nov 30, 2024
View reviewed changes
patch.go
@@ -415,10 +414,10 @@ func (d *partialArray) set(key string, val *lazyNode) error {

if idx < 0 {
if !SupportNegativeIndices {
return errors.Wrapf(ErrInvalidIndex, "Unable to access invalid index: %d", idx)
return fmt.Errorf("Unable to access invalid index: %d : %w", idx, ErrInvalidIndex)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick; this message is one space different from the one on L420.

Suggested change
return fmt.Errorf("Unable to access invalid index: %d : %w", idx, ErrInvalidIndex)
return fmt.Errorf("Unable to access invalid index: %d: %w", idx, ErrInvalidIndex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency github.com/pkg/errors was archived
2 participants
@koba1t @cbandy