Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make distclean blows away include/libint2, resulting in build failures #204

Open
mbanck opened this issue Jan 23, 2021 · 2 comments · May be fixed by #205
Open

make distclean blows away include/libint2, resulting in build failures #204

mbanck opened this issue Jan 23, 2021 · 2 comments · May be fixed by #205
Assignees
Labels

Comments

@mbanck
Copy link
Contributor

mbanck commented Jan 23, 2021

Just running make distclean on a fresh checkout results in include/libint2 being deleted and then a subsequent build failing with an obscure error message about "C++11 support is required" when in fact it can not find ./include/libint2/util/cxxstd.h anymore. I believe it is general development consensus that make distclean should not remove any files required to build the project again from scratch and/or any files from git which can not be regenerated by the build system.

$ LANG=C make distclean
for dir in src tests/eri tests/unit tests/hartree-fock doc tests/eri tests/unit tests/hartree-fock; \
  do \
    (cd ${dir} && make "DODEPEND=no" distclean) || exit 1; \
  done
make[1]: Entering directory '/home/mba/hacking/git/libint/src'
[...]
make[1]: Leaving directory '/home/mba/hacking/git/libint/tests/hartree-fock'
rm -rf autom4te.cache config.status config.log conf*.file conf*.dir *.dSYM depcheck* libtool \
Makedirlist libint2.pc include/libint2
test -f libint2.pc.in || rm -rf include/libint2
$ LANG=C git status | head
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    include/libint2/atom.h
	deleted:    include/libint2/basis.h.in
	deleted:    include/libint2/boys.h
$ ./autogen.sh
$ ./configure
checking build system type... x86_64-pc-linux-gnu
[...]
checking CXX for array... yes
configure: error: C++11 support is required to compile the Libint compiler. Obtain a recent C++ compiler that supports C++11, or consider using a pregenerated library
$ grep conftest.*fatal.error config.log | grep -v ac_nonexistent.h
conftest.cpp:55:18: fatal error: ./include/libint2/util/cxxstd.h: No such file or directory
conftest.cpp:55:19: fatal error: ./include/libint2/util/cxxstd.h: No such file or directory
@e-kwsm
Copy link
Contributor

e-kwsm commented Jan 27, 2021

The directory is removed by

libint/Makefile

Lines 90 to 92 in 5bb5fcf

-rm -rf autom4te.cache config.status config.log conf*.file conf*.dir *.dSYM depcheck* libtool \
Makedirlist libint2.pc include/libint2
test -f libint2.pc.in || rm -rf include/libint2
.

@evaleev
Copy link
Owner

evaleev commented Sep 13, 2021

This will be addressed by #205

@evaleev evaleev linked a pull request Sep 13, 2021 that will close this issue
16 tasks
@evaleev evaleev added the bug label Sep 13, 2021
@evaleev evaleev self-assigned this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants