Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release latest version to fix expand_arg #94

Closed
wmmc88 opened this issue Sep 18, 2023 · 8 comments · Fixed by #102
Closed

Release latest version to fix expand_arg #94

wmmc88 opened this issue Sep 18, 2023 · 8 comments · Fixed by #102

Comments

@wmmc88
Copy link

wmmc88 commented Sep 18, 2023

I was trying to setup macrotest and found that expand_arg was not working to pass my feature flags to the tests. This seems to be an issue with version "1.0.9", because pointing macrotest to the latest commit on main c4151a5 fixed to issue.

The output i got when on "1.0.9" was:

Running 1 macro expansion tests
Expansion error:
error: Package `package v0.0.0 (path/to/package)` does not have the feature `nightly`
@wmmc88
Copy link
Author

wmmc88 commented Sep 21, 2023

not sure if related, but I also get the same errors when using workspace metadata in the cargo.toml: ex. edition.workspace = true

@ijackson
Copy link
Contributor

Another bug fixed on master: #98

@wmmc88
Copy link
Author

wmmc88 commented Mar 29, 2024

@eupn @taiki-e can we get a crates.io release of macrotest?

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 29, 2024

@eupn @taiki-e can we get a crates.io release of macrotest?

(I'm not a maintainer of this crate, so I cannot release a new version. That said I would be happy to help with the maintenance of this crate if @eupn needs help on maintenance.)

@wmmc88
Copy link
Author

wmmc88 commented Mar 29, 2024

@eupn @taiki-e can we get a crates.io release of macrotest?

(I'm not a maintainer of this crate, so I cannot release a new version. That said I would be happy to help with the maintenance of this crate if @eupn needs help on maintenance.)

Woops. My bad. I saw the recent prs and misread it. Thought u were the one who merged them.

@eupn
Copy link
Owner

eupn commented Mar 30, 2024

@taiki-e thanks for the offer, I've sent you an invite on github and crates.io! :3

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 30, 2024

@eupn Thanks! I'll work on a new release.

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 30, 2024

Published v1.0.10.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants