Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendACK() restting SENDERID to 0 #30

Open
jkittley opened this issue Mar 16, 2018 · 0 comments
Open

sendACK() restting SENDERID to 0 #30

jkittley opened this issue Mar 16, 2018 · 0 comments

Comments

@jkittley
Copy link

It looks like the while not self.canSend() loop in sendACK() is resetting all the SENDERID and RSSI values in the class. The reason why is perfectly understandable, however if the sendACK() occurs before the end of the loop i.e. you try to use SENDERID after sending the Acknowledgement this is a bit confusing. Maybe it would be better to have receiveDone() return values so that they are separated? Or just add a comment for idiots like me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant