diff --git a/src/module_wrap.cc b/src/module_wrap.cc index fd3d9c0ceaf317..2efb34c4eeacc3 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -339,8 +339,7 @@ MaybeLocal ModuleWrap::CompileSourceTextModule( bool* cache_rejected) { Isolate* isolate = realm->isolate(); EscapableHandleScope scope(isolate); - ScriptOrigin origin(isolate, - url, + ScriptOrigin origin(url, line_offset, column_offset, true, // is cross origin @@ -580,7 +579,6 @@ void ModuleWrap::Evaluate(const FunctionCallbackInfo& args) { ShouldNotAbortOnUncaughtScope no_abort_scope(realm->env()); TryCatchScope try_catch(realm->env()); - Isolate::SafeForTerminationScope safe_for_termination(isolate); bool timed_out = false; bool received_signal = false; diff --git a/src/node_builtins.cc b/src/node_builtins.cc index 701b67568ebec4..a953a707caae2a 100644 --- a/src/node_builtins.cc +++ b/src/node_builtins.cc @@ -265,7 +265,7 @@ MaybeLocal BuiltinLoader::LookupAndCompileInternal( std::string filename_s = std::string("node:") + id; Local filename = OneByteString(isolate, filename_s.c_str(), filename_s.size()); - ScriptOrigin origin(isolate, filename, 0, 0, true); + ScriptOrigin origin(filename, 0, 0, true); BuiltinCodeCacheData cached_data{}; { diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 98f18eb8979027..4d16b54249e9de 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -853,8 +853,7 @@ void ContextifyScript::New(const FunctionCallbackInfo& args) { host_defined_options->Set( isolate, loader::HostDefinedOptions::kID, id_symbol); - ScriptOrigin origin(isolate, - filename, + ScriptOrigin origin(filename, line_offset, // line offset column_offset, // column offset true, // is cross origin @@ -973,7 +972,7 @@ MaybeLocal CompileFunction(Local context, Local filename, Local content, std::vector>* parameters) { - ScriptOrigin script_origin(context->GetIsolate(), filename, 0, 0, true); + ScriptOrigin script_origin(filename, 0, 0, true); ScriptCompiler::Source script_source(content, script_origin); return ScriptCompiler::CompileFunction(context, @@ -1083,7 +1082,6 @@ bool ContextifyScript::EvalMachine(Local context, } TryCatchScope try_catch(env); - Isolate::SafeForTerminationScope safe_for_termination(env->isolate()); ContextifyScript* wrapped_script; ASSIGN_OR_RETURN_UNWRAP(&wrapped_script, args.This(), false); Local unbound_script = @@ -1237,8 +1235,7 @@ void ContextifyContext::CompileFunction( Local host_defined_options = loader::ModuleWrap::GetHostDefinedOptions(isolate, id_symbol); - ScriptOrigin origin(isolate, - filename, + ScriptOrigin origin(filename, line_offset, // line offset column_offset, // column offset true, // is cross origin @@ -1419,8 +1416,7 @@ static MaybeLocal CompileFunctionForCJSLoader(Environment* env, Local symbol = env->vm_dynamic_import_default_internal(); Local hdo = loader::ModuleWrap::GetHostDefinedOptions(isolate, symbol); - ScriptOrigin origin(isolate, - filename, + ScriptOrigin origin(filename, 0, // line offset 0, // column offset true, // is cross origin diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc index 44d82d759302ac..4b1c300f0c267c 100644 --- a/test/cctest/test_environment.cc +++ b/test/cctest/test_environment.cc @@ -626,7 +626,6 @@ TEST_F(NodeZeroIsolateTestFixture, CtrlCWithOnlySafeTerminationTest) { // Allocate and initialize Isolate. v8::Isolate::CreateParams create_params; create_params.array_buffer_allocator = allocator.get(); - create_params.only_terminate_in_safe_scope = true; v8::Isolate* isolate = v8::Isolate::Allocate(); CHECK_NOT_NULL(isolate); platform->RegisterIsolate(isolate, ¤t_loop);