Skip to content

Conversation

@fabianbl
Copy link
Contributor

Current config.guess script form glog-0.3.5 is not able to guess the system name for an aarch64 architecture (e.g. Jetson TX2).

Copy link

@mfehr mfehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one comment though, will glog_catkin fail if the download of the config file fails? If it is, then you might want to consider adding a retry or sth for people with less stable internet connections (an issue that appears now quite often for some maplab users).

@fabianbl
Copy link
Contributor Author

fabianbl commented Jan 8, 2018

@mfehr haha good point, I will add something. thanks for reviewing!

update:
wget retries to download the files 20 times by default (and actually glog_catkin also need to be downloaded, otherwise cmake will already fail there)

@fabianbl fabianbl merged commit 82db5ff into master Jan 8, 2018
@fabianbl fabianbl deleted the feature/port-to-arm branch January 8, 2018 16:45
@meyerj
Copy link

meyerj commented Jan 26, 2018

Actually #24 would also have fixed this. The repo should not contain those files which are generated by autotools. See also google/glog#188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants