Remove files generated by autotools #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply google/glog#188 and invoke autogen.sh in the configure step. Required to fix build on aarch64 architecture, like google/glog#107.
Contributor
Contributor
|
Closing this for now, this should be fixed with #26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply patch google/glog#188 from upstream that fixes all kind of issues because files generated by autotools have been committed. I was able to build the package on an ARM aarch64 system (Tegra TX2) with this patch, which failed with the same error as reported in #19.
Related issues:
I first applied the patch to eb23bbb which still pulls v0.3.4 of glog and required a slightly different patch and then replaced it with the original patch downloaded from https://github.com/google/glog/commit/4f3e18bf26cdb794fc66cec348f57b5838a0c929.patch in the merge commit. The (additional) patch command hopefully becomes obsolete once glog version 0.3.6 is released and includes commit google/glog@4f3e18b.