Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ant Select minor fixes #5594

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Ant Select minor fixes #5594

merged 2 commits into from
Dec 11, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Dec 11, 2024 •
edited
Loading

Closes HJ-312

Description Of Changes

  • Ant Select component’s hover color is still “Sandstone” but should be “Neutral 50”
  • For multiselect/tags mode, the checkmark should be the Carbon icon and not Ant Icon.

Steps to Confirm

  1. In AdminUI, Open any select and hover the options. Hover color should be "Neutral 50" aka "#fafafa" which is slightly lighter than a selected option.
  2. Open a "tag" mode select (like the Responsibility field when creating a new System) and make a selection. Note that the check icon is slightly different from Ant's default

OLD
old

NEW
new

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 8:31pm

@cypress Cypress
Copy link

cypress bot commented Dec 11, 2024 •
edited
Loading

fides    Run #11448

Run Properties:  status check passed Passed #11448  •  git commit e2f4f4ec07 ℹ️: Merge 3c283583f23b7f909b918eb03febce1e14f42d4b into 9371f6f0b39cad1dd9d8e0a8ae58...
Project fides
Branch Review refs/pull/5594/merge
Run status status check passed Passed #11448
Run duration 00m 58s
Commit git commit e2f4f4ec07 ℹ️: Merge 3c283583f23b7f909b918eb03febce1e14f42d4b into 9371f6f0b39cad1dd9d8e0a8ae58...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

lucanovera
lucanovera approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with the Data categories select and it shows in the correct color now and with the correct arrow. The code looks good as well. Approved.
I don't see the changelog update, you may want to add that.

@gilluminate gilluminate force-pushed the gill/HJ-312/ant-select-is-wrong branch from f77ca72 to 3c28358 Compare December 11, 2024 20:31
@gilluminate gilluminate merged commit 9bbab10 into main Dec 11, 2024
11 checks passed
@gilluminate gilluminate deleted the gill/HJ-312/ant-select-is-wrong branch December 11, 2024 20:32
@cypress Cypress
Copy link

cypress bot commented Dec 11, 2024

fides    Run #11449

Run Properties:  status check passed Passed #11449  •  git commit 9bbab10f1d: Ant Select minor fixes (#5594)
Project fides
Branch Review main
Run status status check passed Passed #11449
Run duration 00m 57s
Commit git commit 9bbab10f1d: Ant Select minor fixes (#5594)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucanovera lucanovera lucanovera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @lucanovera