-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape datetime and ObjectId values in test privacy results #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #11321
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5567/merge
|
Run status |
Passed #11321
|
Run duration | 00m 48s |
Commit |
1c6be11f91 ℹ️: Merge ffe64d392b6d921882ae4bd76c6355db6fc2b4d6 into ca8e8470f38218fd95d448e1cf64...
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
13 tasks
eastandwestwind
approved these changes
Dec 6, 2024
fides Run #11327
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11327
|
Run duration | 00m 49s |
Commit |
3f0c29639d: Escape datetime and ObjectId values in test privacy results (#5567)
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
eastandwestwind
pushed a commit
that referenced
this pull request
Dec 6, 2024
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA-197
Description Of Changes
Fixes and issue where
ObjectId
values from MongoDB weren't being handled correctly by theget_test_privacy_request_results
endpointCode Changes
Steps to Confirm
nox -s dev -- mongodb
Test inputs
Pre-Merge Checklist
main
downgrade()
migration is correct and works