Minor Demo fixes #5566
Minor Demo fixes #5566
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| @@ -153,7 +153,7 @@ const Overlay: FunctionComponent<Props> = ({ | |||
| }, [showBanner, setBannerIsOpen]); | |||
|
|
|||
| useEffect(() => { | |||
| if (!experience || options.modalLinkId === "") { | |||
| if (options.fidesEmbed || !experience || options.modalLinkId === "") { | |||
There was a problem hiding this comment.
we don't want to be constantly polling for a modal link when the CMP is embedded in the page!
| @@ -485,7 +485,7 @@ div#fides-consent-content .fides-modal-description { | |||
| justify-content: center; | |||
| } | |||
|
|
|||
| .fides-modal-container .fides-button-group-brand { | |||
| .fides-modal-footer .fides-button-group-brand { | |||
There was a problem hiding this comment.
.fides-modal-container doesn't exist when things are embedded, so let's target the modal footer class instead.
There was a problem hiding this comment.
Since this component exists in both the modal and the embed, is it worth trying to rename it to something more generic or would that break too much stuff?
There was a problem hiding this comment.
which component are you referring to, the footer or the brand?
There was a problem hiding this comment.
Sorry, the modal footer, that is. Or anything else that's getting used here that has modal in the name, I suppose.
There was a problem hiding this comment.
Yeah, I think eventually we'll want to rename everything as "layer1" and "layer2" instead for that reason. I don't think this now is the time to do that. 👍
| body { | ||
| font-family: "Inter", sans-serif; | ||
| color: #171923; | ||
| font-size: 14px; | ||
| } |
There was a problem hiding this comment.
fonts were all wonky on this page otherwise. This mimics the font choices of the Cookie House homepage.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5566/merge
|
| Run status |
|
| Run duration | 00m 54s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
| @@ -1023,13 +1023,13 @@ div#fides-overlay-wrapper .fides-toggle .fides-toggle-display { | |||
| position: relative; | |||
| } | |||
|
|
|||
| .fides-modal-container .fides-i18n-menu { | |||
| .fides-modal-footer .fides-i18n-menu { | |||
There was a problem hiding this comment.
These styles still don't seem to be applying for me and the i18n menu is still centered, is that intentional?
There was a problem hiding this comment.
weird, that was working for me. Try rebuilding/clearing your cache?
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Some minor fixes for the Embedded Demo page.