Embedded CMP Layer 2 example page #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
gilluminate
commented
Dec 5, 2024
Comment on lines
+60
to
+63
| {/* Require FidesJS to "embed" it's UI onto the page, instead of as an overlay over the <body> itself. (see https://ethyca.com/docs/dev-docs/js/reference/interfaces/FidesOptions#fides_embed) */} | ||
| <script>{`window.fides_overrides = { fides_embed: true, fides_disable_banner: true }`}</script> | ||
| {/* Allow the embedded consent modal to fill the screen */} | ||
| <style>{`#fides-embed-container { --fides-overlay-width: 'auto' }`}</style> |
There was a problem hiding this comment.
These 4 lines are where this example varies from the original Cookie House homepage, in addition to the div below. Everything else is exactly the same.
gilluminate
commented
Dec 5, 2024
| `} | ||
| </Script> | ||
| ) : null} | ||
| <div id="fides-embed-container" /> |
There was a problem hiding this comment.
This div replaces Home component from the Cookie House homepage.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5564/merge
|
| Run status |
|
| Run duration | 00m 57s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
jpople
approved these changes
Dec 5, 2024
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Creating a new sample page that demonstrates how to embed the CMP onto a page. This is useful on its own, but will also be helpful for demonstrating how to load it into a Native mobile web view.
Code Changes
Steps to Confirm
/embedded-consent?geolocation=eeato see the new embedded page/?geolocation=EEAPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works