Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test datasets button for non-database integrations #5560

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Disable test datasets button for non-database integrations #5560

merged 1 commit into from
Dec 5, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 4, 2024 •
edited by jira bot
Loading

Closes LA-193

Description Of Changes

Adding a check to only enable the "Test dataset" button for database integrations.

Code Changes

  • Adding another condition for rendering the "Test dataset" button

Steps to Confirm

  1. Start Fidesplus
  2. Run the Admin UI from this branch
  3. Navigate to the config page for a database integration, add a dataset, the "Test datasets" button should be visible
  4. Navigate to the config page for a SaaS integration, the "Tests dataset" button should not be visible

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:46pm

@galvana galvana marked this pull request as ready for review December 4, 2024 23:42
@cypress Cypress
Copy link

cypress bot commented Dec 4, 2024

fides    Run #11276

Run Properties:  status check passed Passed #11276  •  git commit 4bff2e8a8c ℹ️: Merge 47813f8460d7ed8f82e7876a95ca10677a403033 into ae28e79d9e8244a6b80350a5aec5...
Project fides
Branch Review refs/pull/5560/merge
Run status status check passed Passed #11276
Run duration 00m 48s
Commit git commit 4bff2e8a8c ℹ️: Merge 47813f8460d7ed8f82e7876a95ca10677a403033 into ae28e79d9e8244a6b80350a5aec5...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@galvana galvana merged commit 411c895 into main Dec 5, 2024
13 checks passed
@galvana galvana deleted the LA-193-disable-dataset-test-button-for-SaaS-integrations branch December 5, 2024 17:43
@cypress Cypress
Copy link

cypress bot commented Dec 5, 2024

fides    Run #11288

Run Properties:  status check passed Passed #11288  •  git commit 411c89559e: Disable test datasets button for non-database integrations (#5560)
Project fides
Branch Review main
Run status status check passed Passed #11288
Run duration 00m 49s
Commit git commit 411c89559e: Disable test datasets button for non-database integrations (#5560)
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

galvana added a commit that referenced this pull request Dec 5, 2024
@galvana
Disable test datasets button for non-database integrations (#5560)
b46a426
andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024
@galvana @andres-torres-marroquin
Disable test datasets button for non-database integrations (#5560)
6986333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @eastandwestwind