Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-97 - Missing QA from HJ-97 #5559

Merged
merged 4 commits into from
Dec 5, 2024
Merged

HJ-97 - Missing QA from HJ-97 #5559

merged 4 commits into from
Dec 5, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #HJ-97

Description Of Changes

Missing QA from HJ-97

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 0:48am

adamsachs
adamsachs reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the follow up! some minor recommended adjustments

src/fides/api/api/v1/endpoints/system.py Outdated Show resolved Hide resolved
src/fides/api/api/v1/endpoints/system.py Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Dec 4, 2024 •
edited
Loading

fides    Run #11277

Run Properties:  status check passed Passed #11277  •  git commit e186ead813 ℹ️: Merge ad19214aa3de4ec94424c20248997851ee83e8ac into ae28e79d9e8244a6b80350a5aec5...
Project fides
Branch Review refs/pull/5559/merge
Run status status check passed Passed #11277
Run duration 00m 49s
Commit git commit e186ead813 ℹ️: Merge ad19214aa3de4ec94424c20248997851ee83e8ac into ae28e79d9e8244a6b80350a5aec5...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

adamsachs
adamsachs approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the diligence and follow up 👍

@andres-torres-marroquin andres-torres-marroquin merged commit bb69eb2 into main Dec 5, 2024
37 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-97-QA branch December 5, 2024 14:25
andres-torres-marroquin added a commit that referenced this pull request Dec 5, 2024
@andres-torres-marroquin @adamsachs
HJ-97 - Missing QA from HJ-97 (#5559)
cd95a92 
Co-authored-by: Adam Sachs <[email protected]>
@cypress Cypress
Copy link

cypress bot commented Dec 5, 2024

fides    Run #11282

Run Properties:  status check passed Passed #11282  •  git commit bb69eb246f: HJ-97 - Missing QA from HJ-97 (#5559)
Project fides
Branch Review main
Run status status check passed Passed #11282
Run duration 00m 50s
Commit git commit bb69eb246f: HJ-97 - Missing QA from HJ-97 (#5559)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 11, 2024
@andres-torres-marroquin @adamsachs
HJ-97 - Missing QA from HJ-97 (#5559)
13b9690 
Co-authored-by: Adam Sachs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @adamsachs