Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add op-besu #58

Merged
merged 9 commits into from
Aug 27, 2024
Merged

feat: add op-besu #58

merged 9 commits into from
Aug 27, 2024

Conversation

barnabasbusa
Copy link
Contributor

No description provided.

@barnabasbusa barnabasbusa linked an issue Aug 9, 2024 that may be closed by this pull request
Add op-besu #55
Closed
@barnabasbusa
Copy link
Contributor Author

Currently failing with:

2024-08-09 11:26:07.291+00:00 | main | ERROR | Besu | Failed to start Besu
  java.io.FileNotFoundException: /data/besu/execution-data/VERSION_METADATA.json (No such file or directory)
        at java.base/java.io.FileOutputStream.open0(Native Method)
        at java.base/java.io.FileOutputStream.open(FileOutputStream.java:289)
        at java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:230)
        at java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:179)
        at com.fasterxml.jackson.core.TokenStreamFactory._fileOutputStream(TokenStreamFactory.java:334)
        at com.fasterxml.jackson.core.JsonFactory.createGenerator(JsonFactory.java:1547)
        at com.fasterxml.jackson.databind.ObjectMapper.createGenerator(ObjectMapper.java:1257)
        at com.fasterxml.jackson.databind.ObjectMapper.writeValue(ObjectMapper.java:3980)
        at org.hyperledger.besu.ethereum.core.VersionMetadata.writeToDirectory(VersionMetadata.java:71)
        at org.hyperledger.besu.ethereum.core.VersionMetadata.versionCompatibilityChecks(VersionMetadata.java:119)
        at org.hyperledger.besu.cli.BesuCommand.run(BesuCommand.java:1173)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at org.hyperledger.besu.cli.BesuCommand.lambda$createExecuteTask$1(BesuCommand.java:1100)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at org.hyperledger.besu.cli.BesuCommand.lambda$createPluginRegistrationTask$2(BesuCommand.java:1110)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at org.hyperledger.besu.cli.util.
ConfigDefaultValueProviderStrategy.execute(ConfigDefaultValueProviderStrategy.java:58)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at org.hyperledger.besu.cli.BesuCommand.executeCommandLine(BesuCommand.java:1137)
        at org.hyperledger.besu.cli.BesuCommand.parse(BesuCommand.java:1079)
        at org.hyperledger.besu.Besu.main(Besu.java:41)

cc: @GrapeBaBa

@thinkAfCod
Copy link

The startup parameters should also include --version-compatibility-protection=false to avoid this error.

@barnabasbusa
Copy link
Contributor Author

@thinkAfCod how can pass the rollup's sequencer's IP:port to op-besu? --rollup.sequencerhttp= doesn't seem to be a valid flag.

@barnabasbusa
Copy link
Contributor Author

even with --version-compatibility-protection=false added, I'm still getting the above listed error about the metadata json file missing.

@thinkAfCod
Copy link

The default user for Besu's Docker container is 'besu,' not 'root,' which imposes significant permission restrictions. You can try specifying the data-path to the /opt/besu directory.

@GrapeBaBa
Copy link

The default user for Besu's Docker container is 'besu,' not 'root,' which imposes significant permission restrictions. You can try specifying the data-path to the /opt/besu directory.

@barnabasbusa does it make sense? This is inherited from the origin besu.

@barnabasbusa
Copy link
Contributor Author

@thinkAfCod seems like besu now started up, but seem to be unable to build blocks with op-node:

t=2024-08-26T11:50:12+0000 lvl=error msg="Sequencer temporarily could not seal block" payloadID=0x1dbaadc0b59c8495 timestamp=1724672521 err="failed to seal execution payload (ID: 0x1dbaadc0b59c8495): unrecognized rpc error: Method not enabled"

l1.rpckind is set to standard on op-node.

@barnabasbusa barnabasbusa merged commit 08e7548 into main Aug 27, 2024
5 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/op-besu branch August 27, 2024 12:34
@EthPandaOpsBot EthPandaOpsBot mentioned this pull request Aug 27, 2024
Merged
barnabasbusa added a commit that referenced this pull request Nov 22, 2024
@EthPandaOpsBot @barnabasbusa
chore(main): release 1.1.0 (#37)
ce0887d 
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](1.0.0...1.1.0)
(2024-11-21)


### Features

* add additional configuration options for participants
([#81](#81))
([05d0fe9](05d0fe9))
* add custom configurable forks
([#59](#59))
([878906a](878906a))
* add hildr
([#42](#42))
([e1ce08e](e1ce08e))
* add k8s tests
([#45](#45))
([168f062](168f062))
* add op_contract_deployer_params/image
([#63](#63))
([9416a86](9416a86))
* add op-besu
([#58](#58))
([08e7548](08e7548))
* add op-erigon - mininny
([#38](#38))
([c69bf34](c69bf34))
* add sanity check
([#50](#50))
([ceaa9a9](ceaa9a9))
* Add support for op-deployer, fix multiple L2s
([#74](#74))
([eb59380](eb59380))
* add version.txt
([#36](#36))
([1d10311](1d10311))
* add wait for sync for non kurtosis chains
([#49](#49))
([0452e11](0452e11))
* Adding op-nethermind
([#46](#46))
([fba71dd](fba71dd))
* op-deployer upgrade, fix fork support
([#88](#88))
([f8d9089](f8d9089))
* Output Admin Private Key
([#71](#71))
([95abc10](95abc10))


### Bug Fixes

* ci jobs only notify if discord secret available
([#48](#48))
([9473f89](9473f89))
* contract string
([#82](#82))
([c062de0](c062de0))
* count for participant was not calculated with
([#89](#89))
([f511988](f511988))
* DNS-1035 label
([#44](#44))
([1bf8541](1bf8541))
* erigon perms issue
([#76](#76))
([0328314](0328314))
* explicitly set client contexts0
([30017f2](30017f2))
* force offset time to be int
([#64](#64))
([74b6417](74b6417))
* github action should fail if any jobs fail
([#78](#78))
([577ca3b](577ca3b))
* grammar in docs
([#33](#33))
([d6fb36f](d6fb36f))
* handling of config options
([#85](#85))
([5b085c8](5b085c8))
* image label name too long, truncate at 63 chars
([#90](#90))
([5bd687c](5bd687c))
* l2 contract deployment
([#35](#35))
([3f2b16d](3f2b16d))
* Provide default participants
([#77](#77))
([a7d72da](a7d72da))
* Remove wait for finalization for create2 factory deployment
([#60](#60))
([d4c37f0](d4c37f0))
* test k8s
([#47](#47))
([ac17e89](ac17e89))
* trust l1 rpc in op-node
([#41](#41))
([05dcd2e](05dcd2e))
* Update neth image; improve genesis tool
([#73](#73))
([71e61c8](71e61c8))
* update op-geth hash based storage
([#61](#61))
([f0b5b23](f0b5b23))
* Validate root params
([#79](#79))
([914a808](914a808))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Barnabas Busa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parithosh parithosh parithosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add op-besu
4 participants
@barnabasbusa @thinkAfCod @GrapeBaBa @parithosh