From 8842110c5abb5f7f38c1ce666f6e912c315bc920 Mon Sep 17 00:00:00 2001 From: 0xTylerHolmes Date: Sun, 26 May 2024 14:04:59 -0400 Subject: [PATCH 1/3] fix divide by zero --- src/package_io/input_parser.star | 1 + 1 file changed, 1 insertion(+) diff --git a/src/package_io/input_parser.star b/src/package_io/input_parser.star index 9bb927cfa..324f59aa3 100644 --- a/src/package_io/input_parser.star +++ b/src/package_io/input_parser.star @@ -545,6 +545,7 @@ def parse_network_params(plan, input_args): # If the num validator keys per node is not divisible by vc_count of a participant, fail if ( + participant["vc_count"] > 0 and result["network_params"]["num_validator_keys_per_node"] % participant["vc_count"] != 0 From 061dbec8694e78dfeb2cf9c48d351202866fd6e6 Mon Sep 17 00:00:00 2001 From: 0xTylerHolmes Date: Sun, 26 May 2024 14:24:21 -0400 Subject: [PATCH 2/3] fix index out of bounds issues when vc_count = 0 --- src/cl/cl_launcher.star | 2 +- src/participant_network.star | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cl/cl_launcher.star b/src/cl/cl_launcher.star index 87324d3de..a4e9b6ca8 100644 --- a/src/cl/cl_launcher.star +++ b/src/cl/cl_launcher.star @@ -119,7 +119,7 @@ def launch( cl_service_name = "cl-{0}-{1}-{2}".format(index_str, cl_type, el_type) new_cl_node_validator_keystores = None - if participant.validator_count != 0: + if participant.validator_count != 0 and participant.vc_count != 0: new_cl_node_validator_keystores = preregistered_validator_keys_for_nodes[ index ] diff --git a/src/participant_network.star b/src/participant_network.star index fb1b5f82a..97d0fd25f 100644 --- a/src/participant_network.star +++ b/src/participant_network.star @@ -391,7 +391,11 @@ def launch_participant_network( el_context = all_el_contexts[index] cl_context = all_cl_contexts[index] - vc_context = all_vc_contexts[index] + if participant.vc_count != 0: + vc_context = all_vc_contexts[index] + else: + vc_context = None + if participant.snooper_enabled: snooper_engine_context = all_snooper_engine_contexts[index] From fcaf38a0744ce83812356ac229e05b76ba21049f Mon Sep 17 00:00:00 2001 From: Barnabas Busa Date: Tue, 28 May 2024 11:05:25 +0200 Subject: [PATCH 3/3] fix lint --- src/package_io/input_parser.star | 4 ++-- src/participant_network.star | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/package_io/input_parser.star b/src/package_io/input_parser.star index 324f59aa3..ac54c8d98 100644 --- a/src/package_io/input_parser.star +++ b/src/package_io/input_parser.star @@ -545,8 +545,8 @@ def parse_network_params(plan, input_args): # If the num validator keys per node is not divisible by vc_count of a participant, fail if ( - participant["vc_count"] > 0 and - result["network_params"]["num_validator_keys_per_node"] + participant["vc_count"] > 0 + and result["network_params"]["num_validator_keys_per_node"] % participant["vc_count"] != 0 ): diff --git a/src/participant_network.star b/src/participant_network.star index 97d0fd25f..a3ce56365 100644 --- a/src/participant_network.star +++ b/src/participant_network.star @@ -396,7 +396,6 @@ def launch_participant_network( else: vc_context = None - if participant.snooper_enabled: snooper_engine_context = all_snooper_engine_contexts[index] snooper_beacon_context = all_snooper_beacon_contexts[index]