Fix: Make Interface.from() Full Clone

[adraffy]

Interface.format("json") in v6 implies "minimal" which causes Interface.from() to drop a lot of meta information.

Instead, arg-less format() should be called.

In v5, it's safe to call arg-less format(), as the default is Full
https://github.com/ethers-io/ethers.js/blob/555f16ce7bc6f5fcb40f4c88037f3e4e4182c36c/

// Maybe an interface from an older version, or from a symlinked copy
if (typeof((<any>value).format) === "function") {
    // OLD:
    //return new Interface((<any>value).format("json"));

    // NEW:
    return new Interface((<any>value).format());
}

Alternatively, this could do an additional check for formatJson() from v6.

[ricmoo]

This should only happen when using 2 different versions of v6, since the first check is abi instance Interface, but I think it still makes sense to make that check, since obviously it came up for you at some point, so might sneak up on others too. :)

[ricmoo]

Fixed in v6.12.1. Let me know if you still have any issues.

Thanks! :)

[adraffy]

This should only happen when using 2 different versions of v6, since the first check is abi instance Interface, but I think it still makes sense to make that check, since obviously it came up for you at some point, so might sneak up on others too. :)

Yeah it was rare, I encountered it importing between two projects (where I'm testing local changes in one NPM package from another package before release.) Thanks for the fix!