Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform use of VmError for exceptions #521

Closed
s1na opened this issue May 27, 2019 · 2 comments
Closed

Uniform use of VmError for exceptions #521

s1na opened this issue May 27, 2019 · 2 comments

Comments

@s1na
Copy link
Contributor

s1na commented May 27, 2019

Two minor points about how the VM handles exceptions:

  • In most parts of the evm, exceptions are wrapped in a VmError. There are places however where this is not the case (e.g. in precompiles) and only the error message is returned as a string. This can be made uniform so that all exceptions are wrapped in a VmError.
  • Result objects include two keys: exception and exceptionError. This is redundant. It can be checked whether an exception occured by checking whether exceptionError is null or contains a value.
@holgerd77
Copy link
Member

Not sure what's the state of this, this would need some validation - optimally with some code links - or some comment by @s1na if/what of the above has been solved.

@alcuadrado
Copy link
Member

I think this was fixed in #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants