Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit the Augur RPC tests #13

Open
bobsummerwill opened this issue Sep 11, 2016 · 0 comments
Open

Audit the Augur RPC tests #13

bobsummerwill opened this issue Sep 11, 2016 · 0 comments

Comments

@bobsummerwill
Copy link

Are they more complete than these tests?

What is our best path forward to complete an RPC test suite which covers the whole API surface?

From https://gitter.im/ethcore/parity?at=57d3a416d274dbdf3505ba39, @tinybike says ...

@bobsummerwill sorry just saw your question about tests! Yes, augur's RPC tests are indeed available -- they're the augur.js tests

https://github.com/AugurProject/augur.js

(we also have some generic RPC tests in https://github.com/AugurProject/ethrpc, but most of them are in augur.js)

actually this is a bit awkward because I just overhauled some of our trading functions in augur.js, and so I'm embarrassed to say augur.js has some broken tests on master

this should be fixed over the next few days tho!

CC @winsvega, @karalabe, @chfast.

@bobsummerwill bobsummerwill changed the title Audit the Augur tests Audit the Augur RPC tests Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant