Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues running the test suite. #10

Open
Nashatyrev opened this issue Apr 14, 2016 · 0 comments
Open

Some issues running the test suite. #10

Nashatyrev opened this issue Apr 14, 2016 · 0 comments

Comments

@Nashatyrev
Copy link
Member

First of all thanks for this suite. It helped us much with implementing JSON-RPC for EthereumJ client. Below are some issues we were ran into while running test:

  1. The bcRPC_API_Test.json in its latest state doesn't suite (transactions are absent here), so you need to pick up an earlier revision (e.g. https://github.com/ethereum/tests/blob/c58d3dce3f64f7ee1f711054fc464202bb0b7d64/BlockchainTests/bcRPC_API_Test.json)
  2. With earlier revision there is another issue: some transaction signatures doesn't conform to the latest Frontier requirements (r < SECP256K1N && s < SECP256K1N) so I needed to relax this restriction in my testing env
  3. The following test changes have been made (IMHO test bugs):
diff --git a/test/eth_getTransactionBy.js b/test/eth_getTransactionBy.js
index 261f77f..2c56956 100644
--- a/test/eth_getTransactionBy.js
+++ b/test/eth_getTransactionBy.js
@@ -22,9 +22,9 @@ var asyncTest = function(host, done, method, params, block, index){
             assert.isNull(result.result);
         else if(block === 'pending') {
             assert.isObject(result.result, 'is object');
-            assert.isNull(result.transactionIndex);
-            assert.isNull(result.blockNumber);
-            assert.isNull(result.blockHash);
+            assert.isNull(result.result.transactionIndex);
+            assert.isNull(result.result.blockNumber);
+            assert.isNull(result.result.blockHash);
         } else {

Due to spec eth_newBlockFilter has no params:

diff --git a/test/eth_uninstallFilter.js b/test/eth_uninstallFilter.js
index f196631..10f2114 100644
--- a/test/eth_uninstallFilter.js
+++ b/test/eth_uninstallFilter.js
@@ -56,7 +56,7 @@ describe(method, function(){
                     id: config.rpcMessageId++, jsonrpc: "2.0", method: 'eth_newBlockFilter',

                     // PARAMETERS
-                    params: ['latest']
+                    params: []

                 }, function(blockFilterId){
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant