Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction origin and transaction salt in Account Abstraction #370

Closed
NIC619 opened this issue Feb 13, 2018 · 2 comments
Closed

Transaction origin and transaction salt in Account Abstraction #370

NIC619 opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels

Comments

@NIC619
Copy link
Contributor

NIC619 commented Feb 13, 2018

What is wrong?

In account abstraction, now origin of the transaction(transaction.origin) is always the sender - ENTRY_POINT(0xffff…ffff) and it's meaningless in a contract's context. transaction.origin should probably be changed from transaction.sender to transaction.target or if origin of the transaction no longer holds significant meaning in account abstraction(e.g, it's just a contract that verifies signature, pays for gas and then forwards to another contract. A real account of a user may be composed of many contracts.) it probably can be removed.

Also I'm working on removing gas price from transaction format. As discussed in #326 , one option is to add salt to transaction format(perhaps adding salt for short term and transitioning to EIP232 transaction format for long term?).

How can it be fixed

  • transaction origin
    • 1.1 change transaction origin from transaction.sender to transaction.target
    • 1.2 remove transaction origin
    • 1.3 ?
  • salt
    • 2.1 add salt to transaction format
    • 2.2 EIP232 transaction format
    • 2.3 2.1 for short term and 2.2 for long term
    • 2.4 ?
@NIC619 NIC619 added the eth2.0 label Feb 13, 2018
@lrettig
Copy link
Contributor

lrettig commented Feb 14, 2018

Linking #262 and #366 -- this will impact those.

@hwwhww
Copy link
Contributor

hwwhww commented Mar 27, 2018

close via #422

@hwwhww hwwhww closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants