Fix call artifact identity resolution#2068
Merged
Merged
Conversation
780c48b to
a1c3a9a
Compare
a1c3a9a to
4d6a798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The pipeline treated date plus inferred topic prefix as enough to recover from missing Zoom mappings. That made an incorrect recording look valid and allowed it into the manifest.
The pipeline now requires a mapped occurrence identity for numbered artifacts and uses existing artifact directories only after the target call is known.
Validation
.github/ACDbot/.venv/bin/python -m pytest .github/ACDbot/tests.github/ACDbot/.venv/bin/python .github/ACDbot/scripts/asset_pipeline/generate_manifest.pyvalidate,GitGuardian Security Checks