Skip to content

accounts/keystore: Ignore initial trigger of rescan-event#15527

Merged
karalabe merged 1 commit into
ethereum:masterfrom
holiman:bump_watch
Nov 20, 2017
Merged

accounts/keystore: Ignore initial trigger of rescan-event#15527
karalabe merged 1 commit into
ethereum:masterfrom
holiman:bump_watch

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Nov 20, 2017

We're not doing the initial scan from the watch, which is there to react to fs events. Thus we can ignore the initial trigger, which is just a side-effect of being unable to create an unitialized timer.

@holiman holiman requested a review from karalabe November 20, 2017 11:36
Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.7.3 milestone Nov 20, 2017
@karalabe karalabe merged commit 7b95cca into ethereum:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants