Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: move gas estimator into core, dedup in simulated backend #28570

Closed
karalabe opened this issue Nov 21, 2023 · 0 comments · Fixed by #28600
Closed

rpc: move gas estimator into core, dedup in simulated backend #28570

karalabe opened this issue Nov 21, 2023 · 0 comments · Fixed by #28600
Assignees

Comments

@karalabe
Copy link
Member

Currently we have 2 gas estimators. One in internals/ethapi, the other in the simulated backend. This was kind of acceptable when they were a few liners, but now we have some extra optimizations in place for the main one but which wasn't ported into the simulated one. Also it's not an exactly testable part of our code.

TL;DR: We should move the gas estimation logic into core, either into it's own package or along with something else and have the RPCs only call it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant