Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner on the console #18243

Closed
adamschmideg opened this issue Dec 4, 2018 · 14 comments · Fixed by #24759
Closed

Banner on the console #18243

adamschmideg opened this issue Dec 4, 2018 · 14 comments · Fixed by #24759

Comments

@adamschmideg
Copy link
Contributor

Print a banner on the console with general information. If --dev was specified, add "welcome to power user mode".

@MartinDawson
Copy link
Contributor

Can you please provide some more details on what this banner should contain and look like? Thanks!

@holiman
Copy link
Contributor

holiman commented Jan 15, 2019

Let's collect some ideas here...

  • If user is in dev-mode, it should print out some info about what this mode even means (e..g all keys are ephemeral).
  • If user is using insecure configurations, it should warn about that
  • It might print out some info about where to file tickets

@lhendre
Copy link
Contributor

lhendre commented Feb 19, 2019

It could also list any important config options that arent already displayed or are defaulted in, the warning for insecure configurations could include details, additionally it could include the licensing information which is the GNU Lesser General Public License v3.0 I believe.

Also what should be included for insecure configuration? And should tickets be linked to the github page then?

Node info and an accounts list may be nice?

@stale
Copy link

stale bot commented Feb 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@natclark
Copy link

I would personally find this feature very useful, and I would be more than happy to implement it if someone wants to assign me!

@adamschmideg
Copy link
Contributor Author

@nathanio that's good news. Please be aware it's not thoroughly specified, so part of the job is to figure it out :)

@natclark
Copy link

Hey, just a quick question. One issue I've noticed is that the console gets filled up so quickly when dev mode is run that it can be difficult to read the banner. Should I make it so that the user has to press a key when they run --dev to confirm? The console would just show the banner in the meantime, giving the user a chance to read it.

@adamschmideg
Copy link
Contributor Author

I'm asking around in the team

@ligi
Copy link
Member

ligi commented May 22, 2020

Should I make it so that the user has to press a key when they run --dev to confirm?

please don't. This can break current setups and if things are headless might cause some WTFs, broken workflows and wasted time. Maybe a sleep after the banner - but then we need another flag to disable this.

@natclark
Copy link

Should I make it so that the user has to press a key when they run --dev to confirm?

please don't. This can break current setups and if things are headless might cause some WTFs, broken workflows and wasted time. Maybe a sleep after the banner - but then we need another flag to disable this.

Yes, this was my exact concern. And you are completely right about having the option to disable the sleep/prompt. A better option might be having the banners disabled by default, and then the users that need them could manually enable them.

@fjl fjl assigned s1na Feb 4, 2021
@solrac97gr
Copy link

Hi, What is the status of this Issue? someone is already working in this?

@s1na
Copy link
Contributor

s1na commented Mar 23, 2022

@solrac97gr It's open for taking if someone wants to work on it. I've had it on my backlog for a year and kind of forgot about it

@solrac97gr
Copy link

forking and starting to work in this) if you have some suggestion for start?

@s1na
Copy link
Contributor

s1na commented Mar 23, 2022

@solrac97gr I'd start with collecting the information that might be useful before coding up anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants