From b686f8b912654d690b0d9bbf890a6f34f174967b Mon Sep 17 00:00:00 2001 From: Jochem Brouwer Date: Fri, 20 Feb 2026 15:42:42 +0100 Subject: [PATCH 1/2] fix(benchmarks): ensure sstore N->N writes nonzero key/value --- tests/benchmark/compute/instruction/test_storage.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/benchmark/compute/instruction/test_storage.py b/tests/benchmark/compute/instruction/test_storage.py index 44edc54d3e..3c615137e4 100644 --- a/tests/benchmark/compute/instruction/test_storage.py +++ b/tests/benchmark/compute/instruction/test_storage.py @@ -501,7 +501,9 @@ def test_storage_access_warm_benchmark( """ match storage_action: case StorageAction.WRITE_SAME_VALUE: - attack_block = Op.SSTORE(Op.PUSH0, Op.PUSH0) + # Timestamp is nonzero (no txs run in Genesis block), so this always writes + # to the zero key a nonzero, constant value + attack_block = Op.SSTORE(Op.PUSH0, Op.TIMESTAMP) case StorageAction.WRITE_NEW_VALUE: attack_block = Op.SSTORE(Op.PUSH0, Op.GAS) case StorageAction.READ: From c2caf0e2165604f0093bbdecf5085b959638fccd Mon Sep 17 00:00:00 2001 From: LouisTsai Date: Tue, 24 Feb 2026 14:55:18 +0800 Subject: [PATCH 2/2] fix: linting issue --- tests/benchmark/compute/instruction/test_storage.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/benchmark/compute/instruction/test_storage.py b/tests/benchmark/compute/instruction/test_storage.py index 3c615137e4..c99608475a 100644 --- a/tests/benchmark/compute/instruction/test_storage.py +++ b/tests/benchmark/compute/instruction/test_storage.py @@ -501,8 +501,8 @@ def test_storage_access_warm_benchmark( """ match storage_action: case StorageAction.WRITE_SAME_VALUE: - # Timestamp is nonzero (no txs run in Genesis block), so this always writes - # to the zero key a nonzero, constant value + # Timestamp is nonzero (no txs run in Genesis block), + # Always writes to the zero key a nonzero, constant value attack_block = Op.SSTORE(Op.PUSH0, Op.TIMESTAMP) case StorageAction.WRITE_NEW_VALUE: attack_block = Op.SSTORE(Op.PUSH0, Op.GAS)