Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block methods missing required? #583

Open
m4sterbunny opened this issue Sep 12, 2024 · 1 comment
Open

block methods missing required? #583

m4sterbunny opened this issue Sep 12, 2024 · 1 comment

Comments

@m4sterbunny
Copy link

m4sterbunny commented Sep 12, 2024

  1. eth_getBlockTransactionCountByHash propose that the param is required

params:
- name: Block hash
required: true

  1. eth_getBlockTransactionCountByNumber propose that the param is required

params:
- name: Block number
required: true

  1. eth_getUncleCountByBlockHash ditto
    params:

    • name: Block hash
      required: true
  2. eth_getUncleCountByBlockNumber ditto

@m4sterbunny
Copy link
Author

Note, that stating required reduces the number of automated tests that will be run, without required, testing will be forced to run with parameter and without and then interpret error as logical, not true error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant