Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge methods accessing accounts #124

Open
chfast opened this issue Aug 31, 2018 · 4 comments
Open

Merge methods accessing accounts #124

chfast opened this issue Aug 31, 2018 · 4 comments
Projects

Comments

@chfast
Copy link
Member

chfast commented Aug 31, 2018

Instead of

get_balance()
get_code_hash()
get_code_size()

have

struct account
{
  balance
  code_size
  code_hash
}
get_account() -> account

Replaces #117.

@axic
Copy link
Member

axic commented Sep 3, 2018

Shouldn't include account_exists?

@chfast
Copy link
Member Author

chfast commented Sep 3, 2018

For non-existing accounts the get_account() should return some kind of null value.

@axic
Copy link
Member

axic commented Sep 3, 2018

I see two options:

  1. returns struct account, but has a field within: int exists.
  2. takes pointer to struct account and returns int

I think 1) may be nicer if we want to avoid pointers.

@axic axic added this to To do in v7.0 via automation Sep 5, 2018
@axic
Copy link
Member

axic commented Aug 22, 2019

@chfast are you tackling this for 7?

@chfast chfast removed this from To do in v7.0 Sep 19, 2019
@axic axic added this to To do in v8.0 via automation Dec 3, 2019
@axic axic removed this from To do in v8.0 Apr 30, 2021
@axic axic added this to To do in v9.0 via automation Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v9.0
To do
Development

No branches or pull requests

2 participants