fix: miss heading id#18024
Merged
Merged
Conversation
jzhishu
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
wackerow
approved these changes
Apr 23, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Thanks @jzhishu, good catch!
And to your comment about a markdownlint rule, yes! That has since been implemented, along with several updates to our translation pipeline.
The existing content was produced prior to those updates, but soon we should be running another full pass of the website which should enforce the exact thing your fixing and the rule your commenting about. Thanks again!
Member
|
@all-contributors please add @jzhishu for bug fix |
Contributor
|
I've put up a pull request to add @jzhishu! 🎉 |
This was referenced Apr 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a broken anchor link on the
/zh/contributing/page.The heading on line 88 of
public/content/translations/zh/contributing/index.mdwas missing a space before{#new-to-open-source}, causing theremark-heading-idplugin to silently drop the ID. As a result, the heading was rendered without anidattribute and anchor links to#new-to-open-sourcedid not work.Related Issue
https://github.com/ethereum/ethereum-org-website/issues/18023
Follow-up suggestion
Perhaps a new markdownlint rule could be added to handle this and prevent recurrence.