fix(intl-pipeline): pending-branch baseline + docs refresh#17997
Merged
Conversation
Document pending-as-baseline behavior, temp branch lifecycle, base-branch-moved-during-run handling, non-English file edit policy with stamp-only escape hatch, and the orchestration contract. Rename "staging branch" to "pending branch" throughout for consistency with intl/pending-<base> naming. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
When the pending branch already exists for the base (prior run), merge base into pending first and fail fast on conflict, then use pending as the baseline for drift detection and the temp branch source. This prevents non-deterministic LLM output from re-translating unchanged sections and causing merge conflicts on subsequent runs against the same base. Rename ensureStagingBranch to ensurePendingBranch for consistency with intl/pending-<base> naming. Add deleteBranch helper to clean up tmp-intl/ branches after successful merge into pending. Drop "v5" from the pipeline log header. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
- PIPELINE-SPEC: add forward reference to Orchestration under Inputs; drop stale 'Git operations' and 'PR creation' entries from "What this spec does NOT cover"; reframe non-English edit policy from flat "do not hand-edit" to the manifest-mapping rule, with explicit Allowed / Not allowed examples; route the escape hatch through intl-pipeline.yml stamp_only input. - AGENTS.md: consolidate Internationalization section; capture the pipeline-is-single-propagator rule, the stamp_only workflow escape hatch, the allowance for translation-error fixes, and a pointer to PIPELINE-SPEC. - main.ts: comment the local-tree reset block as CI-only. - review-translations: migrate from the deprecated ethereum.org glossary endpoint to ETHGlossary; resolve the base URL at runtime from GLOSSARY_API_URL env var or config.ts default so the skill stays correct when the host changes; fetch llms.txt as the canonical endpoint reference; prefer POST /filter (per-file scope) over full-language fetches for efficiency; tighten the Phase 3 mandatory block and bottom notes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Remove items that have shipped: comment-restoration concatenation fix (gemini.ts passes strippedCode into restoreComments); glossary enforcement (covered by ETHGlossary migration plus the updated review-translations skill); transliteration banks (now in language-groups.ts and prompt-builder.ts). Relabel split-PRs as nice-to-have and note that the revival must adapt to today's per-base pending-branch orchestration rather than cherry-pick the old SPLIT_PRS implementation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intl/pending-<base>branch as baseline on re-runs so non-deterministic LLM output doesn't re-translate unchanged sections or produce merge conflicts. Merges base into pending first and fails fast on conflict; temp branches now branch off pending and are cleaned up after successful merge.tests/specs/PIPELINE-SPEC.md: pending-branch lifecycle, temp-branch lifecycle, base-moved-during-run handling, and the non-English file edit policy (manifest-mapping rule, with thestamp_onlyworkflow input as the escape hatch).AGENTS.mdto capture the single-propagator rule and point agents at the spec./review-translationsslash command from the deprecatedethereum.org/api/glossaryendpoint to ETHGlossary. Base URL resolves at runtime fromGLOSSARY_API_URLenv var or theconfig.tsdefault so it stays correct when the host changes. PrefersPOST /filterfor per-file scoped lookups.FUTURE.md: remove items that have shipped; relabel split-PRs as nice-to-have with a note on the pending-branch orchestration nuance.Test plan
intl-pipeline.ymlagainst a test base with no existing pending branch (first-run path)./review-translationsagainst a PR and confirm ETHGlossary endpoints resolve viaGLOSSARY_API_URLandllms.txtfetch succeeds.