fix(e2e): update whitepaper test to match new PDF link text#17256
Merged
Conversation
PR #17190 changed the PDF download link text from a sentence containing "whitepaper...PDF" to "Download original PDF (2014)". Update the test regex to match the new link text.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Use href-based selection which is more robust than matching link text. The PDF filename is stable, while link text may change with UI updates.
Merged
wackerow
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PR #17190 changed the PDF download link text from:
to:
The existing test regex
/whitepaper.*pdf/ino longer matched because "whitepaper" is not in the new link text.Solution
Instead of matching link text (which is fragile and can change with UI updates), the test now selects the PDF link by its href containing the stable filename
Ethereum_Whitepaper_-_Buterin_2014.pdf.This approach is more robust because:
Test plan