Conversation
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
github-actions
Bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
requested changes
Jul 15, 2025
| "page-trillion-dollar-security-hero-paragraph-4": "Companies, institutions, and governments are comfortable storing more than 1 trillion dollars of value inside a single contract or application, and are comfortable transacting in comparable amounts.", | ||
| "page-trillion-dollar-security-hero-paragraph-5": "The Trillion Dollar Security (1TS) project is an ecosystem-wide effort to upgrade Ethereum's security. This report is the first deliverable of the 1TS project. Over the last month, we have gathered feedback from users, developers, security experts, and institutions about where they see the biggest challenges and areas for improvement. Thank you to the hundreds of people and dozens of organizations who have taken the time to share your insights with us.", | ||
| "page-trillion-dollar-security-hero-paragraph-5": "The <a>Trillion Dollar Security (1TS)</a> project is an ecosystem-wide effort to upgrade Ethereum's security. This report is the first deliverable of the 1TS project. Over the last month, we have gathered feedback from users, developers, security experts, and institutions about where they see the biggest challenges and areas for improvement. Thank you to the hundreds of people and dozens of organizations who have taken the time to share your insights with us.", | ||
| "page-trillion-dollar-security-hero-paragraph-5-link": "https://blog.ethereum.org/2025/05/14/trillion-dollar-security", |
Member
There was a problem hiding this comment.
Suggested change
| "page-trillion-dollar-security-hero-paragraph-5-link": "https://blog.ethereum.org/2025/05/14/trillion-dollar-security", |
Comment on lines
+111
to
+113
| href={t( | ||
| "page-trillion-dollar-security-hero-paragraph-5-link" | ||
| )} |
Member
There was a problem hiding this comment.
Suggested change
| href={t( | |
| "page-trillion-dollar-security-hero-paragraph-5-link" | |
| )} | |
| href="https://blog.ethereum.org/2025/05/14/trillion-dollar-security" |
Any reason we can't place the link directly in here? No need for the link to be translated
|
|
||
| <p>{t("page-trillion-dollar-security-hero-paragraph-5")}</p> | ||
| <p> | ||
| {t.rich("page-trillion-dollar-security-hero-paragraph-5", { |
Member
There was a problem hiding this comment.
Thanks for this! Hadn't figured this out yet, but this solves the server-side htmr challenges, and also allows us to inject any variable this way using variations of a <span></span>.
wackerow
approved these changes
Jul 15, 2025
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Went ahead and made that change.. cc: @pettinarip gonna pull this in, but let me know if you disagree with that adjustment—can patch if needed
This was referenced Jul 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.