refactor: migrate usage of InfoBanner to ui/alert#15414
Conversation
✅ Deploy Preview for ethereumorg canceled.
|
github-actions
Bot
added
content 🖋️
JoeChenJ
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
JoeChenJ
changed the title
|
This is great @JoeChenJ! Thanks so much... Massive diff! But spot checking this so far it looks to be working great... will try to give this a more detailed review soon. |
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
This looks great, thanks @JoeChenJ!... checking it over it seems to work very well... looks nice aligned with the theme 🤩 g/j
cc: @lukassim This updates a significant number of translated files, AND removes a component from the repo (InfoBanner). If we don't update Crowdin we'll end up pulling reverting these changes which would try to use a component that no longer exists. When we pull this in, just want to make sure we're able to update Crowdin to avoid this. Thoughts on best approach?
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
the
Status: Stale
JoeChenJ
force-pushed
the
Migrate_InfoBanner_to_Alert
branch
from
10e32f7 to
812d5e5
Compare
wackerow
added
Update Crowdin
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
This looks great @JoeChenJ, thanks again! Cleared the conflicts and patched a couple small things I noticed. Building successfully for me locally so pulling this in... can patch any additional small regressions we note as they come. 🎉
2 participants
Description
Migrate usage of InfoBanner to ui/alert
Related Issue
ui/alertcomponents #15407