Skip to content

refactor(tailwind): apply max-width-screen-* usage#14940

Merged
pettinarip merged 6 commits into
ethereum:devfrom
TylerAPfledderer:refactor/tailwind-max-w-screens
Mar 11, 2025
Merged

refactor(tailwind): apply max-width-screen-* usage#14940
pettinarip merged 6 commits into
ethereum:devfrom
TylerAPfledderer:refactor/tailwind-max-w-screens

Conversation

@TylerAPfledderer
Copy link
Copy Markdown
Contributor

@TylerAPfledderer TylerAPfledderer commented Feb 19, 2025

Replaces explicit use of breakpoint values with max-w-screen-* to apply these values to max-width.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8781434
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67cf2cacc2f526000732b4b7
😎 Deploy Preview https://deploy-preview-14940--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🔴 down 9 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we misusing this class?

Looks like what we really want to use is max-w-screen- instead of max-w-. Wouldn't overriding maxWidth be redundant?

If we override it, shouldn't we also override the minWidth classes?

@TylerAPfledderer
Copy link
Copy Markdown
Contributor Author

Aren't we misusing this class?

Looks like what we really want to use is max-w-screen- instead of max-w-. Wouldn't overriding maxWidth be redundant?

If we override it, shouldn't we also override the minWidth classes?

@pettinarip Yep. I overlooked that utility when going through the docs.

I'll revert and apply this utility.

@TylerAPfledderer TylerAPfledderer changed the title refactor(tailwind.config): use current breakpoint set in maxWidth scale refactor(tailwind): apply max-width-screen-* usage Mar 10, 2025
@TylerAPfledderer
Copy link
Copy Markdown
Contributor Author

TylerAPfledderer commented Mar 10, 2025

@pettinarip alright, should be good here.

Chromatic regressions shown are outstanding from previous PRs (that I will review). I saw no regressions in the list specific to the changes made here.

Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks good thanks @TylerAPfledderer

@pettinarip pettinarip merged commit 95b1067 into ethereum:dev Mar 11, 2025
@TylerAPfledderer TylerAPfledderer deleted the refactor/tailwind-max-w-screens branch March 11, 2025 12:03
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants