refactor(tailwind): apply max-width-screen-* usage#14940
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
left a comment
There was a problem hiding this comment.
Aren't we misusing this class?
Looks like what we really want to use is max-w-screen- instead of max-w-. Wouldn't overriding maxWidth be redundant?
If we override it, shouldn't we also override the minWidth classes?
@pettinarip Yep. I overlooked that utility when going through the docs. I'll revert and apply this utility. |
max-width-screen-* usage
|
@pettinarip alright, should be good here. Chromatic regressions shown are outstanding from previous PRs (that I will review). I saw no regressions in the list specific to the changes made here. |
pettinarip
left a comment
There was a problem hiding this comment.
Nice! looks good thanks @TylerAPfledderer

Replaces explicit use of breakpoint values with
max-w-screen-*to apply these values to max-width.