[ShadCN]: migrate ConnectWeb3 Simulator Screen#14861
Merged
pettinarip merged 12 commits intoFeb 11, 2025
Merged
Conversation
…eb3-simulator-screen
TylerAPfledderer
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
reviewed
Feb 11, 2025
| outline: "", // Base styling | ||
| ghost: "border-transparent hover:shadow-none", | ||
| link: "border-transparent hover:shadow-none underline py-0 px-1 active:text-primary", | ||
| link: "border-transparent hover:shadow-none underline !min-h-0 !py-0 !px-1 active:text-primary", |
Member
There was a problem hiding this comment.
👍🏼 weird case where we are doing sizing things in the variant... xd
pettinarip
approved these changes
Feb 11, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Great @TylerAPfledderer. I cleaned up some console logs.
TylerAPfledderer
deleted the
feat/shadcn-connectweb3-simulator-screen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate
ConnectWeb3simulator screen components to ShadCN/Tailwind.Creates a set of stories using the main screen component.