[ShadCN]: Migrate MergeInfographic#14853
Merged
pettinarip merged 3 commits intoFeb 10, 2025
Merged
Conversation
TylerAPfledderer
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
force-pushed
the
feat/mergeinfographic-tailwind
branch
2 times, most recently
from
7c38c36 to
7acb8e6
Compare
TylerAPfledderer
force-pushed
the
feat/mergeinfographic-tailwind
branch
from
7acb8e6 to
1d1f65b
Compare
pettinarip
approved these changes
Feb 10, 2025
| ...rest | ||
| }: SVGTextElementAttributes<SVGTextElement>) => ( | ||
| <text | ||
| className={cn("fill-current [text-anchor:start]", className)} |
Member
There was a problem hiding this comment.
didn't know that you could do that (arbitrary props) TIL
Contributor
Author
There was a problem hiding this comment.
@pettinarip ah yes! Applies to any case where you need to explicitly write a CSS property and value. Of course, you lose the ability to apply a token.
This includes creating CSS variables as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.