[ShadCN]: Implement ShadCN Avatar to Production#14814
Conversation
TylerAPfledderer
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| w={10} | ||
| display={{ base: "none", xs: "block" }} | ||
| // This meets the Design System requirement, despite not being used in this instance | ||
| href="#" |
There was a problem hiding this comment.
Could we align it with the link for the row?
| href="#" | |
| href={hasGitHub ? `${GITHUB_URL}${username}` : "#"} |
There was a problem hiding this comment.
If not the user gets this ux where the avatar link is upside the linkbox making it a weird experience
02-03-2025-16.11.56.mp4
There was a problem hiding this comment.
Hmmm, I wasn't expecting that! I'll go ahead with your suggestion here.
For future consideration the avatar shouldn't really be hoverable here unless styled based on hover over the rest of the list item, correct?
There was a problem hiding this comment.
Yes, correct. For this transition, we will leave it as is, but ideally only the row should be the element that gets the hover effect.
|
@pettinarip should be all set with the changes here! |
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
LGTM! thanks @TylerAPfledderer
2 participants
Description
Applies the newest Avatar component to all current instances:
IssuesList.tsx,FileContributors.tsx, andLeaderboard.tsxTwo points of note related to the Design System:
Leaderboard.tsxto adhere to the DS, where it is required to supply a value to thehrefprop. It is believed that it is better to address this requirement in the short term with a comment and using#as the value in the component instance, instead of making the prop an optional type. This should not be noticeable to the user.10. This value is not being used in any of thesizevariants in the DS, and therefore explicitly set in the given instances.Related Issue
Minor impact approaching migrations done for the above affected components in #13946