Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest a wallet: Ctrl Wallet (fka XDEFI Wallet) #13467

Closed
2 tasks
sean-mc-grath opened this issue Jul 24, 2024 · 17 comments · Fixed by #14263
Closed
2 tasks

Suggest a wallet: Ctrl Wallet (fka XDEFI Wallet) #13467

sean-mc-grath opened this issue Jul 24, 2024 · 17 comments · Fixed by #14263
Labels
awaiting PR Issue is ready for a pull request good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help product 🧰 This involves a product listing wallet 👛 This issue relates to adding or changing a wallet

Comments

@sean-mc-grath
Copy link

Wallet name

Ctrl Wallet

What type of wallet?

EOA

Wallet description

One wallet for all your assets. Multichain wallet that displays all assets and NFTs on 200+ networks.

Wallet logo

App Icon Black

Background color for brand logo

#FFFFFF

URL to the project

https://ctrl.xyz/

When did the wallet go live to users?

XDEFI has been live since 2020, Ctrl rebrand will be live in September 2024

What are the fees users may be paying for using your wallet product?

No fees on general usage or transactions.
0.3% fee on in-app swaps & bridges, with discounts for token holders.

Does the wallet have an active development team?

Yes. https://github.com/XDeFi-tech/ctrl-extension/

Is the wallet globally accessible?

Globally accessible everywhere crypto is legal.

Is the wallet available in multiple languages?

Currently available in English with more languages coming soon.

What social links are there for the project?

https://discord.gg/ctrlwallet
https://x.com/ctrl_wallet
https://t.me/ctrl_wallet

Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?

Yes, iOS & Android

Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?

N/A

Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?

Yes, Chromium

Is it a hardware wallet?

No

What is the availability of your source code?

Open source

What license is the wallet software released under?

This project is licensed under the Apache-2.0 License.

Who holds the private keys?

Ctrl is a self-custody wallet, we never have access to users private keys. Users have full control over their keys.

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

Security audit by FYEO currently underway.
Previously audited by Kudelski Security.

Has the wallet's smart contract code or security modules been audited?

https://www.xdefi.io/wp-content/uploads/2021/07/XDEFI_Audit_Report_Kudelski.pdf

Does the wallet have an internal security team?

No

Any other security testing that should be noted?

N/A

Scam protection?

Yes, integrations with a number of third party security providers, covering:

  • Malicious domain detection and warning
  • Malicious address scanning
  • Transaction simulation
  • Transaction and message signing risk analysis

Does the wallet support connecting to Ethereum applications?

Extension: connect wallet to dapp directly, Mobile: WalletConnect

Does the wallet support connecting to a hardware wallet?

Yes

Does the wallet support importing Ethereum RPC endpoints?

Yes

Does the wallet support viewing and interacting with NFTs?

Yes

Does the wallet support staking directly?

No

Does the wallet support swaps directly?

Yes: https://docs.xdefi.io/docs/general/routing

Does the wallet support bridging directly?

Yes: https://docs.xdefi.io/docs/general/routing

Does the wallet support multi-chain networks?

Yes. 36 chains natively + hundreds more possible to add by the user. https://docs.xdefi.io/docs

Does the wallet support Ethereum layer 2 networks?

Yes: https://docs.xdefi.io/docs

Does the wallet allow the user to customize gas fees?

Yes:

Does the wallet support sending transactions to ENS addresses?

Yes

Does the wallet support importing or automatically querying and displaying ERC-20 tokens?

Yes

Does the wallet support EIP-1559 (type 2) transactions?

Yes

Does the wallet have any recovery options?

Recovery via:

  • Recovery Phrase
  • Private Key
  • Hardware Wallet import
  • Social Log Ins (web3auth)
  • JSON back up

Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?

Yes

Does the wallet support withdrawals to fiat?

Yes

Is the wallet a multi-signature wallet?

No

Does the wallet support social recovery?

Yes: web3auth integrated

Does the wallet support bundled transactions?

No

Who can the ethereum.org team can contact regarding the wallet in future?

https://discord.gg/ctrlwallet
https://x.com/ctrl_wallet
https://t.me/ctrl_wallet

Does the wallet have a dedicated support team?

Yes, support available via discord or intercom on the website.
Dedicated support team available almost 24/7 with very fast response (less than 30 mins)

What educational resources/documentation do you provide to users?

User support: https://intercom.help/ctrlwallet/en/
Developer support: https://docs.xdefi.io/docs

Does the wallet have any integrated tools not mentioned above?

No response

Would you like to work on this issue?

  • Yes
  • No
@sean-mc-grath sean-mc-grath added product 🧰 This involves a product listing wallet 👛 This issue relates to adding or changing a wallet labels Jul 24, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 24, 2024
@konopkja
Copy link
Contributor

konopkja commented Jul 24, 2024

Does the wallet support Ethereum layer 2 networks?
Arbitrum
Optimism
Custom EVM

@konopkja
Copy link
Contributor

whoever makes the PR, please also update last time updated metadata

@sean-mc-grath
Copy link
Author

@konopkja yes Ctrl supports Arbitrum & Optimism natively, and all EVMs are possible to be added as custom networks.

@wackerow wackerow added needs product review 🕵️ Product listing request in need of review and removed needs triage 📥 This issue needs triaged before being worked on labels Jul 24, 2024
@wackerow
Copy link
Member

@konopkja Have you been able to review this yet? If so just go ahead and update labels (remove "needs product review", add "awaiting PR, help wanted, good first issue") and remove yourself from assignment. Thanks!

@sean-mc-grath Was this something you wanted to implement if/when ready for a PR?

@konopkja konopkja added awaiting PR Issue is ready for a pull request good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help and removed needs product review 🕵️ Product listing request in need of review labels Jul 24, 2024
@sean-mc-grath
Copy link
Author

Hey @wackerow , sorry not sure what the question is, let me know if there's any other actions I need to take to get the listing approved and live?

@wackerow
Copy link
Member

@sean-mc-grath No action now, I'm just checking with @konopkja to see if he's finished with any reviews of Ctrl Wallet since this is a new listing...

Once approved, we'll just need someone to implement the updates. Is this something you'd like to be assigned to handle when the time comes, or would you prefer someone else to make the actual code adjustments?

@sean-mc-grath
Copy link
Author

Thanks @wackerow , if possible would be great to have somebody on your side make the code adjustments, I'm not a dev so better to leave it to somebody with the expertise

@wackerow
Copy link
Member

Sounds good @sean-mc-grath! Thanks for letting us know, will handle it

@konopkja konopkja removed their assignment Jul 24, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 24, 2024
@0xshikhar
Copy link

Hey @konopkja , would like to work on this task. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@konopkja
Copy link
Contributor

Hey @konopkja , would like to work on this task. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

create PR with changed metadata for this particular wallet here https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-data.ts

want to do that?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 24, 2024
@konopkja
Copy link
Contributor

Screenshot 2024-10-30 at 10 09 40

hi @sean-mc-grath - can you please elaborate on why the extension has not been renamed and why there is a warning for users? when is this going to be updated?

@konopkja
Copy link
Contributor

furthermore, @sean-mc-grath i see you indicated that the app has android and ios versions, but i see the links on the website for those disabled

@konopkja
Copy link
Contributor

@sean-mc-grath
Copy link
Author

Hey @konopkja , the migration from XDEFI to Ctrl is currently in progress - the XDEFI extension is still live for now, and the warning is as it is not updated to MV3 per Google guidelines. The Ctrl extension is MV3 compatible, and will migrate fully in production for all users by mid-November. You can find more details here: https://ctrl.xyz/xdefi-wallet-rebranding-to-ctrl/ & https://ctrl.xyz/news/manifest-v3/

Both Ctrl extension and mobile apps are available for beta testing, if helpful please let me know your email (associated with chrome for extension) and I can add you to beta group to download and review

@konopkja
Copy link
Contributor

Hey @konopkja , the migration from XDEFI to Ctrl is currently in progress - the XDEFI extension is still live for now, and the warning is as it is not updated to MV3 per Google guidelines. The Ctrl extension is MV3 compatible, and will migrate fully in production for all users by mid-November. You can find more details here: https://ctrl.xyz/xdefi-wallet-rebranding-to-ctrl/ & https://ctrl.xyz/news/manifest-v3/

Both Ctrl extension and mobile apps are available for beta testing, if helpful please let me know your email (associated with chrome for extension) and I can add you to beta group to download and review

ok so should we rebrand already on https://ethereum.org/en/wallets/find-wallet/ your listing or wait till december?

@sean-mc-grath
Copy link
Author

We are happy for it to be rebranded now already yes so it is ready in advance, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting PR Issue is ready for a pull request good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help product 🧰 This involves a product listing wallet 👛 This issue relates to adding or changing a wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants