Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create stories for Header components #13050

Open
3 tasks
Tracked by #13043
corwintines opened this issue May 27, 2024 · 5 comments
Open
3 tasks
Tracked by #13043

Create stories for Header components #13050

corwintines opened this issue May 27, 2024 · 5 comments
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Milestone
Implementation of...

Comments

@corwintines
Copy link
Member

corwintines commented May 27, 2024 •
edited
Loading

Create stories for the following header components:

  • LanguagePicker
  • Nav
  • Search
@corwintines corwintines mentioned this issue May 27, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 27, 2024
@corwintines corwintines changed the title Header (break this down in another issue) [WIP] Header (break this down in another issue) May 27, 2024
@corwintines corwintines changed the title [WIP] Header (break this down in another issue) Create stories for Header components May 28, 2024
@wackerow wackerow added feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help and removed needs triage 📥 This issue needs triaged before being worked on dev required This requires developer resources labels Jun 6, 2024
@wackerow wackerow added this to the 13043 milestone Jun 7, 2024
@wackerow wackerow added good first issue Good item to try if you're new to contributing and removed good first issue Good item to try if you're new to contributing labels Jun 13, 2024
@amit-ksh
Copy link
Contributor

hi @corwintines, I'd like to work on this

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Jun 23, 2024 •
edited
Loading

Hey @amit-ksh! Making a quick comment here for reference for you and @corwintines.

In review of these components, I believe the only one marked for visual testing would be the Nav, which is fine to start with since it couples the initial rendering of Search and LanguagePicker.

Two thoughts here if we are considering individual stories for this GH issue with Search and LanguagePicker

  1. There only needs to be one story for each, but as an interactive test with the play function so that Chromatic can take a snapshot of the open modals.
  2. For Search, make sure environment variables used are available in the storybook environment with the testing api keys provided by DocSearch. If not having these keys available in the main .env file, then need to look to the Storybook Config.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 24, 2024
@Spoorthy1423
Copy link

Hey!! @TylerAPfledderer I would like to work on this issue, please assign me

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
Implementation of visual testing epic...
Development

No branches or pull requests
5 participants
@corwintines @wackerow @TylerAPfledderer @amit-ksh @Spoorthy1423