Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace one image for a component on the L2 page #12304

Closed
2 tasks
nloureiro opened this issue Feb 27, 2024 · 13 comments
Closed
2 tasks

Replace one image for a component on the L2 page #12304

nloureiro opened this issue Feb 27, 2024 · 13 comments
Assignees
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new

Comments

@nloureiro
Copy link
Contributor

Is your feature request related to a problem? Please describe.

To improve the comprehension on the L2 page, I propose to change one image with an existing component used on the vision page.

from here > https://ethereum.org/roadmap/visionto here https://ethereum.org/layer-2

Describe the solution you'd like

In the section "Why do we need layer 2?" we describe what and mention scalability and a link to the "blockchain trilemma."

We have an excellent visual reference on the vision page that helps us understand this and can be helpful on the layer page.

The only difference would be to remove some text and make it vertical.

Screen Shot 2024-02-27 12 05 18 AM

Here are the changes/ports from this component.
Screen Shot 2024-02-27 12 06 29 AM

Describe alternatives you've considered

not alternatives at this point, but open to ideas

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@nloureiro nloureiro added the feature ✨ This is enhancing something existing or creating something new label Feb 27, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 27, 2024
@minimalsm
Copy link
Contributor

Like the idea @nloureiro.

This component has fairly unique behaviour on mobile. Do you propose keeping it the same?

@nloureiro
Copy link
Contributor Author

Like the idea @nloureiro.

This component has fairly unique behaviour on mobile. Do you propose keeping it the same?

yes, I would say that it's working well as it is we should keep it, and I assume it's easier to port to this page.

@altinocoelho
Copy link
Contributor

@nloureiro I would like to help with this one

@nloureiro
Copy link
Contributor Author

@nloureiro I would like to help with this one

Awesome. it's yours :)
Let me know if you need any help.
Thank you

@wackerow
Copy link
Member

@nloureiro Are you proposing we move the component (remove from /vision)? Or duplicate it's use (both pages)? Just expressing caution against reusing the exact same copy which can hurt SEO scoring

@wackerow wackerow added dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 19, 2024
@nloureiro
Copy link
Contributor Author

@nloureiro Are you proposing we move the component (remove from /vision)? Or duplicate it's use (both pages)? Just expressing caution against reusing the exact same copy which can hurt SEO scoring

My take was to use it on both pages. I think it's relevant to both content structures.
Do you have any idea how to do it without messing with the SEO?

@wackerow
Copy link
Member

Typically just not reusing the exact same copy helps

@reetbatra
Copy link
Contributor

If this is still pending, may I please take this up?

@nloureiro
Copy link
Contributor Author

If this is still pending, may I please take this up?

Yes. I guess...

@altinocoelho, do you have any updates? Can we pass it over to @reetbatra ?

The timing is great. @TylerAPfledderer 🤘just updated the original component, and we merged it yesterday with dev.

Thank you for reaching out

@altinocoelho
Copy link
Contributor

Sorry for the delay.

If @reetbatra is still interested, she can take it.

Otherwise, I'll look into it in the next few days.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 17, 2024
@corwintines corwintines removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 17, 2024
@corwintines
Copy link
Member

Removing the stale tag here. @nloureiro is this still something you are interested in seeing?

@nloureiro
Copy link
Contributor Author

Removing the stale tag here. @nloureiro is this still something you are interested in seeing?

In light of the new L2 epic we can close this issue. no longer worth the change.
calling out @konopkja to see if this idea can be used on the new pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Development

No branches or pull requests

6 participants