Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate & replace luxon with native solutions #12019

Closed
pettinarip opened this issue Jan 25, 2024 · 1 comment · Fixed by #12209
Closed

Investigate & replace luxon with native solutions #12019

pettinarip opened this issue Jan 25, 2024 · 1 comment · Fixed by #12209
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@pettinarip
Copy link
Member

We’re importing luxon package for very few operations (date manipulation) that could potentially be replaced with a native implementation using JS native Date API or DateTimeFormat. Investigate the feasibility of this.
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 25, 2024
@corwintines corwintines added good first issue Good item to try if you're new to contributing dev required This requires developer resources labels Feb 1, 2024
@isabelladebrito isabelladebrito removed the needs triage 📥 This issue needs triaged before being worked on label Feb 1, 2024
@corwintines corwintines added the help wanted Extra attention is needed or someone is needed to help label Feb 1, 2024
@nhsz nhsz mentioned this issue Feb 16, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove luxon package, replace with JS Intl library ethereum/ethereum-org-website
3 participants
@pettinarip @corwintines @isabelladebrito