Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated image on #10948

Closed
2 tasks
nloureiro opened this issue Aug 16, 2023 · 4 comments · Fixed by #12100
Closed
2 tasks

translated image on #10948

nloureiro opened this issue Aug 16, 2023 · 4 comments · Fixed by #12100
Assignees
Labels
bug 🐛 Something isn't working design All the issues related to design should use this tag

Comments

@nloureiro
Copy link
Contributor

Describe the bug

this image has text outside of the box on the translated version
image

original image
image

To reproduce

  1. Go to https://ethereum.org/en/developers/docs/transactions/#on-gas
  2. view the pt-br
  3. Scroll down to /#on-gas section
  4. See error

Expected behavior

should be inside the box

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@nloureiro nloureiro added the bug 🐛 Something isn't working label Aug 16, 2023
@nloureiro nloureiro self-assigned this Aug 16, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 16, 2023
@rafarocha
Copy link

Weird. I checked the translation and both have equal tspan definitions. It has the same value properties at dy=21 and different font styles.

Inside a tspan I don't know how to fix this. Maybe, changing the script that generates the images. How do I reproduce to process and generate images by language?

Externally<tspan x="120.834" dy="21">owned account</tspan>
Conta de <tspan x="120.834" dy="21">propriedade externa</tspan>

Text translation
https://crowdin.com/translate/ethereum-org/7769/en-ptbr?filter=basic&value=3

Image english
https://ethereum.org/static/c3638b26a1210d2c73a7ec2335c57351/302a4/gas-tx.png

Image pt-br
https://ethereum.org/static/7739f5cc6e54a00841b83dc84c8328e1/302a4/gas-tx.png

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 28, 2023
@corwintines corwintines added design All the issues related to design should use this tag and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Feb 1, 2024
@corwintines
Copy link
Member

@nloureiro This still appears to be an issue, but I think this has to be done in figma. Are you the right one to update this image?

@nloureiro nloureiro linked a pull request Feb 2, 2024 that will close this issue
@nloureiro
Copy link
Contributor Author

@nloureiro This still appears to be an issue, but I think this has to be done in figma. Are you the right one to update this image?

I fix the image and created a PR > #12100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design All the issues related to design should use this tag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@rafarocha @nloureiro @corwintines @lukassim and others