Skip to content

Update fork trigger sections #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Update fork trigger sections #4208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8279ff7
chore: improve forks.md wording
GabrielAstieres Mar 25, 2025
a7b2e1c
fix error in pending consolidation test
GabrielAstieres Mar 26, 2025
8cd4efc
fix ponctuation
GabrielAstieres Mar 26, 2025
1095486
Merge branch 'dev' into chore/cleanup
jtraglia Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions specs/_features/eip7732/fork.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ def compute_fork_version(epoch: Epoch) -> Version:

### Fork trigger

TBD. This fork is defined for testing purposes, the EIP may be combined with other
consensus-layer upgrade.
For now, we assume the condition will be triggered at epoch `EIP7732_FORK_EPOCH`.
The fork is triggered at epoch `EIP7732_FORK_EPOCH`. The EIP may be combined with other consensus-layer upgrade.

### Upgrading the state

Expand Down
3 changes: 1 addition & 2 deletions specs/deneb/fork.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ def compute_fork_version(epoch: Epoch) -> Version:

### Fork trigger

TBD. This fork is defined for testing purposes.
For now, we assume the condition will be triggered at epoch `DENEB_FORK_EPOCH`.
The fork is triggered at epoch `DENEB_FORK_EPOCH`.

Note that for the pure Deneb networks, we don't apply `upgrade_to_deneb` since it starts with Deneb version logic.

Expand Down
2 changes: 1 addition & 1 deletion specs/electra/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,7 @@ def process_consolidation_request(
switch_to_compounding_validator(state, source_index)
return

# Verify that source != target, so a consolidation cannot be used as an exit.
# Verify that source != target, so a consolidation cannot be used as an exit
if consolidation_request.source_pubkey == consolidation_request.target_pubkey:
return
# If the pending consolidations queue is full, consolidation requests are ignored
Expand Down
3 changes: 1 addition & 2 deletions specs/electra/fork.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ def compute_fork_version(epoch: Epoch) -> Version:

### Fork trigger

TBD. This fork is defined for testing purposes, the EIP may be combined with other consensus-layer upgrade.
For now, we assume the condition will be triggered at epoch `ELECTRA_FORK_EPOCH`.
The fork is triggered at epoch `ELECTRA_FORK_EPOCH`.

Note that for the pure Electra networks, we don't apply `upgrade_to_electra` since it starts with Electra version logic.

Expand Down
3 changes: 1 addition & 2 deletions specs/fulu/fork.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ def compute_fork_version(epoch: Epoch) -> Version:

### Fork trigger

TBD. This fork is defined for testing purposes, the EIP may be combined with other consensus-layer upgrade.
For now, we assume the condition will be triggered at epoch `FULU_FORK_EPOCH`.
The fork is triggered at epoch `FULU_FORK_EPOCH`.

Note that for the pure Fulu networks, we don't apply `upgrade_to_fulu` since it starts with Fulu version logic.

Expand Down