For the most part, rename whisk to eip7441 #4131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Feb 16, 2025
configs/minimal.yaml
Outdated
Comment on lines
180
to
181
| WHISK_EPOCHS_PER_SHUFFLING_PHASE: 4 | ||
| WHISK_PROPOSER_SELECTION_GAP: 1 |
Contributor
There was a problem hiding this comment.
we might want to rename these to at least remove whisk?
Member
Author
There was a problem hiding this comment.
Yes, I had the same thought. I would like to remove "WHISK" from these variables. In your opinion, would it be appropriate to do it in this PR or should I do this in a follow up PR?
Contributor
There was a problem hiding this comment.
We're in it now, i'd probably just do it here...
rolfyone
reviewed
Feb 16, 2025
Contributor
rolfyone
left a comment
rolfyone
left a comment
There was a problem hiding this comment.
LGTM mostly, just wondering if we rename constants a little still...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So whisk stands out in the
_featuresdirectory. Other features use EIP names. I think whisk should too.I didn't touch any of the field names or (non-fork) constants. That stuff doesn't really matter in my opinion.
PS: I plan on moving
custody_game,das, andshardingto a new_stagnantdirectory later.