Skip to content

Conversation

@SeanLuis
Copy link
Contributor

Description

This EIP introduces a standardized interface for DeFi protocols to implement verifiable solvency proofs.

Template Checklist

  • Using official EIP template
  • Draft PR
  • Author field includes GitHub username in
  • Email matches public GitHub email
  • Build passes
  • Follows EIP format specifications

Changes

  • Added new EIP draft for DeFi Protocol Solvency Proof Mechanism
  • File: ERCS/eip-draft.md

Test Results

  • All automated tests passing
  • Reference implementation validated
  • Mathematical models verified

Related Links

  • Discussion Thread: [TBD - will create after PR feedback]
  • Reference Implementation: Link

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 25, 2025

✅ All reviewers have approved.

@SeanLuis
Copy link
Contributor Author

I attach a video of the tests carried out using a frontend interface

Screen.Recording.2025-02-03.at.09.24.30.mov

For more details about the EIP, this is the complete repository with the implementations and tests: Link

@SeanLuis SeanLuis changed the title DeFi Protocol Solvency Proof Mechanism Add ERC: DeFi Protocol Solvency Proof Mechanism Feb 25, 2025
@github-actions github-actions bot added the w-ci label Feb 25, 2025
@github-actions github-actions bot added w-ci and removed w-ci labels Feb 26, 2025
@SeanLuis SeanLuis requested a review from bomanaps February 26, 2025 12:47
…e management to Specification, and switch images to SVG

- Added a plain English section explaining how the interface works, per review feedback.
- Moved the optional oracle management section into the Specification, right after the interface definition.
- Removed the redundant oracle management note from Implementation Considerations.
- Updated image links to use SVGs instead of PNGs for better scalability.
auto-merge was automatically disabled June 17, 2025 13:35

Head branch was pushed to by a user without write access

@SeanLuis SeanLuis dismissed stale reviews from eip-review-bot and SamWilsn via fa4f921 June 17, 2025 13:35
@github-actions
Copy link

The commit 200bbaf (as a parent of 3bdcb62) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Jul 15, 2025
@SeanLuis SeanLuis requested a review from SamWilsn July 21, 2025 03:27
Comment on lines +555 to +568
Key security considerations include:

1. Oracle Security:
- Multiple price feed sources
- Manipulation resistance
- Fallback mechanisms

2. Access Control:
- Authorized updaters
- Rate limiting

3. Risk Management:
- Threshold calibration
- Alert system reliability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't really concrete considerations, nor do you mention how to solve/mitigate them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @SamWilsn, those are way too generic. Let me fix the security section with actual implementation details, some code examples, and proper references to existing patterns. I'll update it with concrete numbers and real-world mitigation strategies.

@eip-review-bot eip-review-bot enabled auto-merge (squash) September 15, 2025 20:18
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 383ae7f into ethereum:master Sep 15, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants