-
Notifications
You must be signed in to change notification settings - Fork 830
Add ERC: DeFi Protocol Solvency Proof Mechanism #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All reviewers have approved. |
|
I attach a video of the tests carried out using a frontend interface Screen.Recording.2025-02-03.at.09.24.30.movFor more details about the EIP, this is the complete repository with the implementations and tests: Link |
Update of typescript code blocks for solidity
…e management to Specification, and switch images to SVG - Added a plain English section explaining how the interface works, per review feedback. - Moved the optional oracle management section into the Specification, right after the interface definition. - Removed the redundant oracle management note from Implementation Considerations. - Updated image links to use SVGs instead of PNGs for better scalability.
Head branch was pushed to by a user without write access
|
The commit 200bbaf (as a parent of 3bdcb62) contains errors. |
| Key security considerations include: | ||
|
|
||
| 1. Oracle Security: | ||
| - Multiple price feed sources | ||
| - Manipulation resistance | ||
| - Fallback mechanisms | ||
|
|
||
| 2. Access Control: | ||
| - Authorized updaters | ||
| - Rate limiting | ||
|
|
||
| 3. Risk Management: | ||
| - Threshold calibration | ||
| - Alert system reliability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't really concrete considerations, nor do you mention how to solve/mitigate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @SamWilsn, those are way too generic. Let me fix the security section with actual implementation details, some code examples, and proper references to existing patterns. I'll update it with concrete numbers and real-world mitigation strategies.
eip-review-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Description
This EIP introduces a standardized interface for DeFi protocols to implement verifiable solvency proofs.
Template Checklist
Changes
Test Results
Related Links