Skip to content

Commit ef67e56

Browse files
authored
Update ERC-6220: fix some typos (#970)
Signed-off-by: jimmycathy <[email protected]>
1 parent f8500a5 commit ef67e56

File tree

7 files changed

+24
-24
lines changed

7 files changed

+24
-24
lines changed

ERCS/erc-6220.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ interface IERC6220 is IERC5773 /*, ERC165 */ {
153153
154154
/**
155155
* @notice Used to equip a child into a token.
156-
* @dev The `IntakeEquip` stuct contains the following data:
156+
* @dev The `IntakeEquip` struct contains the following data:
157157
* [
158158
* tokenId,
159159
* childIndex,

assets/erc-6220/contracts/Catalog.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ contract Catalog is ICatalog {
4848
/**
4949
* @notice Used to limit execution of functions intended for the `Slot` parts to only execute when used with such
5050
* parts.
51-
* @dev Reverts execution of a function if the part with associated `partId` is uninitailized or is `Fixed`.
51+
* @dev Reverts execution of a function if the part with associated `partId` is uninitialized or is `Fixed`.
5252
* @param partId ID of the part that we want the function to interact with
5353
*/
5454
modifier onlySlot(uint64 partId) {
@@ -161,7 +161,7 @@ contract Catalog is ICatalog {
161161
* @notice Internal function used to set the new list of `equippableAddresses`.
162162
* @dev Overwrites existing `equippableAddresses`.
163163
* @dev Can only be called on `Part`s of `Slot` type.
164-
* @param partId ID of the `Part`s that we are overwiting the `equippableAddresses` for
164+
* @param partId ID of the `Part`s that we are overwriting the `equippableAddresses` for
165165
* @param equippableAddresses A full array of addresses that can be equipped into this `Part`
166166
*/
167167
function _setEquippableAddresses(

assets/erc-6220/contracts/EquippableToken.sol

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ contract EquippableToken is
603603
// At this point we know pendingRecursiveBurns must be at least 1
604604
pendingRecursiveBurns = maxChildrenBurns - totalChildBurns;
605605
}
606-
// We substract one to the next level to count for the token being burned, then add it again on returns
606+
// We subtract one to the next level to count for the token being burned, then add it again on returns
607607
// This is to allow the behavior of 0 recursive burns meaning only the current token is deleted.
608608
totalChildBurns +=
609609
IERC6059(children[i].contractAddress).burn(
@@ -788,7 +788,7 @@ contract EquippableToken is
788788
* ]
789789
* @param parentId ID of the parent token for which the pending child token is being retrieved
790790
* @param index Index of the child token in the parent token's pending child tokens array
791-
* @return struct A Child struct containting data about the specified child
791+
* @return struct A Child struct containing data about the specified child
792792
*/
793793
function pendingChildOf(
794794
uint256 parentId,
@@ -1398,7 +1398,7 @@ contract EquippableToken is
13981398

13991399
/**
14001400
* @notice Rejects all assets from the pending array of a given token.
1401-
* @dev Effecitvely deletes the pending array.
1401+
* @dev Effectively deletes the pending array.
14021402
* @dev Requirements:
14031403
*
14041404
* - The caller must own the token or be approved to manage the token's assets
@@ -1419,7 +1419,7 @@ contract EquippableToken is
14191419
* @notice Sets a new priority array for a given token.
14201420
* @dev The priority array is a non-sequential list of `uint16`s, where the lowest value is considered highest
14211421
* priority.
1422-
* @dev Value `0` of a priority is a special case equivalent to unitialized.
1422+
* @dev Value `0` of a priority is a special case equivalent to uninitialized.
14231423
* @dev Requirements:
14241424
*
14251425
* - The caller must own the token or be approved to manage the token's assets
@@ -1575,7 +1575,7 @@ contract EquippableToken is
15751575
/**
15761576
* @notice Used to reject all of the pending assets for the given token.
15771577
* @dev When rejecting all assets, the pending array is indiscriminately cleared.
1578-
* @dev If the number of pending assets is greater than the value of `maxRejections`, the exectuion will be
1578+
* @dev If the number of pending assets is greater than the value of `maxRejections`, the execution will be
15791579
* reverted.
15801580
* @param tokenId ID of the token to reject all of the pending assets.
15811581
* @param maxRejections Maximum number of expected assets to reject, used to prevent from
@@ -1775,7 +1775,7 @@ contract EquippableToken is
17751775
* @dev If the `Slot` already has an item equipped, the execution will be reverted.
17761776
* @dev If the child can't be used in the given `Slot`, the execution will be reverted.
17771777
* @dev If the catalog doesn't allow this equip to happen, the execution will be reverted.
1778-
* @dev The `IntakeEquip` stuct contains the following data:
1778+
* @dev The `IntakeEquip` struct contains the following data:
17791779
* [
17801780
* tokenId,
17811781
* childIndex,
@@ -2269,7 +2269,7 @@ contract EquippableToken is
22692269
* ]
22702270
* @dev To learn more about hooks, head to xref:ROOT:extending-contracts.adoc#using-hooks[Using Hooks].
22712271
* @param parentId ID of the token that has accepted a pending child token
2272-
* @param childIndex Index of the child token that was accpeted in the given parent token's pending children array
2272+
* @param childIndex Index of the child token that was accepted in the given parent token's pending children array
22732273
* @param childAddress Address of the collection smart contract of the child token that was expected to be located
22742274
* at the specified index of the given parent token's pending children array
22752275
* @param childId ID of the child token that was expected to be located at the specified index of the given parent

assets/erc-6220/contracts/IERC6220.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ interface IERC6220 is IERC5773 {
9595

9696
/**
9797
* @notice Used to equip a child into a token.
98-
* @dev The `IntakeEquip` stuct contains the following data:
98+
* @dev The `IntakeEquip` struct contains the following data:
9999
* [
100100
* tokenId,
101101
* childIndex,

assets/erc-6220/contracts/utils/EquipRenderUtils.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ contract EquipRenderUtils {
294294
* @return metadataURI Metadata URI of the asset
295295
* @return equippableGroupId Equippable group ID of the asset
296296
* @return catalogAddress Address of the catalog to which the asset belongs to
297-
* @return fixedParts An array of fixed parts respresented by the `FixedPart` structs present on the asset
297+
* @return fixedParts An array of fixed parts represented by the `FixedPart` structs present on the asset
298298
* @return slotParts An array of slot parts represented by the `EquippedSlotPart` structs present on the asset
299299
*/
300300
function composeEquippables(

assets/erc-6220/test/multiasset.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ describe("MultiAsset", async () => {
335335
});
336336

337337
describe("Overwriting assets", async function () {
338-
it("can add asset to token overwritting an existing one", async function () {
338+
it("can add asset to token overwriting an existing one", async function () {
339339
const resId = 1;
340340
const resId2 = 2;
341341
const tokenId = 1;

assets/erc-6220/test/nestable.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ describe("NestableToken", function () {
159159
const childId1 = 99;
160160
await child.nestMint(parent.address, childId1, parentId);
161161

162-
// owner is the same adress
162+
// owner is the same address
163163
expect(await parent.ownerOf(parentId)).to.equal(tokenOwner.address);
164164
expect(await child.ownerOf(childId1)).to.equal(tokenOwner.address);
165165

@@ -1356,7 +1356,7 @@ describe("NestableToken", function () {
13561356
await child.mint(firstOwner.address, childId1);
13571357
});
13581358

1359-
it("cannot nest tranfer from non immediate owner (owner of parent)", async function () {
1359+
it("cannot nest transfer from non immediate owner (owner of parent)", async function () {
13601360
const otherParentId = 2;
13611361
await parent.mint(firstOwner.address, otherParentId);
13621362
// We send it to the parent first
@@ -1371,7 +1371,7 @@ describe("NestableToken", function () {
13711371
).to.be.revertedWithCustomError(child, "NotApprovedOrDirectOwner");
13721372
});
13731373

1374-
it("cannot nest tranfer to same NFT", async function () {
1374+
it("cannot nest transfer to same NFT", async function () {
13751375
// We can no longer nest transfer it, even if we are the root owner:
13761376
await expect(
13771377
child
@@ -1380,7 +1380,7 @@ describe("NestableToken", function () {
13801380
).to.be.revertedWithCustomError(child, "NestableTransferToSelf");
13811381
});
13821382

1383-
it("cannot nest tranfer a descendant same NFT", async function () {
1383+
it("cannot nest transfer a descendant same NFT", async function () {
13841384
// We can no longer nest transfer it, even if we are the root owner:
13851385
await child
13861386
.connect(firstOwner)
@@ -1402,7 +1402,7 @@ describe("NestableToken", function () {
14021402
).to.be.revertedWithCustomError(child, "NestableTransferToDescendant");
14031403
});
14041404

1405-
it("cannot nest tranfer if ancestors tree is too deep", async function () {
1405+
it("cannot nest transfer if ancestors tree is too deep", async function () {
14061406
let lastId = childId1;
14071407
for (let i = 101; i <= 200; i++) {
14081408
await child.nestMint(child.address, i, lastId);
@@ -1415,20 +1415,20 @@ describe("NestableToken", function () {
14151415
).to.be.revertedWithCustomError(child, "NestableTooDeep");
14161416
});
14171417

1418-
it("cannot nest tranfer if not owner", async function () {
1418+
it("cannot nest transfer if not owner", async function () {
14191419
const notOwner = addrs[3];
14201420
await expect(
14211421
child.connect(notOwner).nestTransfer(parent.address, childId1, parentId)
14221422
).to.be.revertedWithCustomError(child, "NotApprovedOrDirectOwner");
14231423
});
14241424

1425-
it("cannot nest tranfer to address 0", async function () {
1425+
it("cannot nest transfer to address 0", async function () {
14261426
await expect(
14271427
child.connect(firstOwner).nestTransfer(ADDRESS_ZERO, childId1, parentId)
14281428
).to.be.revertedWithCustomError(child, "ERC721TransferToTheZeroAddress");
14291429
});
14301430

1431-
it("cannot nest tranfer to a non contract", async function () {
1431+
it("cannot nest transfer to a non contract", async function () {
14321432
const newOwner = addrs[2];
14331433
await expect(
14341434
child
@@ -1437,7 +1437,7 @@ describe("NestableToken", function () {
14371437
).to.be.revertedWithCustomError(child, "IsNotContract");
14381438
});
14391439

1440-
it("cannot nest tranfer to contract if it does implement INestable", async function () {
1440+
it("cannot nest transfer to contract if it does implement INestable", async function () {
14411441
const ERC721 = await ethers.getContractFactory("ERC721Mock");
14421442
const nonNestable = await ERC721.deploy("Non receiver", "NR");
14431443
await nonNestable.deployed();
@@ -1451,7 +1451,7 @@ describe("NestableToken", function () {
14511451
);
14521452
});
14531453

1454-
it("can nest tranfer to INestable contract", async function () {
1454+
it("can nest transfer to INestable contract", async function () {
14551455
await child
14561456
.connect(firstOwner)
14571457
.nestTransfer(parent.address, childId1, parentId);
@@ -1463,7 +1463,7 @@ describe("NestableToken", function () {
14631463
]);
14641464
});
14651465

1466-
it("cannot nest tranfer to non existing parent token", async function () {
1466+
it("cannot nest transfer to non existing parent token", async function () {
14671467
const notExistingParentId = 9999;
14681468
await expect(
14691469
child

0 commit comments

Comments
 (0)